Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong configuration variable used in supporting external python scripts #7

Closed
marche147 opened this issue Jun 14, 2017 · 1 comment
Closed

Comments

@marche147
Copy link
Collaborator

marche147 commented Jun 14, 2017

As pr #5 pointed out, there used to be an old bug related to wrong variable usage causing the external python script malfunction , according to the code below in the latest commit:

                // step 3: parser
                String pOutFile = scOutFile.replace(MiniCCCfg.MINICC_SCANNER_OUTPUT_EXT, MiniCCCfg.MINICC_PARSER_OUTPUT_EXT);

                if(parsing.skip.equals("false")){
                        if(parsing.type.equals("java")){
                                if(parsing.path != ""){
                                        Class<?> c = Class.forName(parsing.path);
                                        Method method = c.getMethod("run", String.class, String.class);
                                        method.invoke(c.newInstance(), scOutFile, pOutFile);
                                }else{
                                        MiniCCParser p = new MiniCCParser();
                                        p.run(pOutFile);
                                }
                        }else if(pp.type.equals("python")){ // <------- 'pp' was used instead of 'parsing'
                                this.runPy(scOutFile, pOutFile, parsing.path);
                        }else{
                                this.run(scOutFile, pOutFile, parsing.path);
                        }
                }

please fix this bug asap.

@marche147
Copy link
Collaborator Author

Closed as fixed in commit a580a23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant