Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: jj git fetch creates an empty change with [[--scope]] settings being ignored #5603

Closed
teenjuna opened this issue Feb 6, 2025 · 3 comments

Comments

@teenjuna
Copy link

teenjuna commented Feb 6, 2025

Description

I use different identity settings for personal stuff and work, e.g. in my config file I have something like this:

[user]
name = "Alex"
email = "alex@personal.com"

[[--scope]]
--when.repositories = ["~/Git/git.work.com"]
[--scope.user]
name = "Alex"
email = "alex@work.com"

When I freshly clone a work-related repo inside ~/Git/git.work.com and jj log inside it, I see this:

@  rtwzklzt alex@personal.com 2025-02-06 15:16:51 a0cd8d2a
│  (empty) (no description set)
◆  vqqvouzl alex@work.com 2025-02-06 15:09:51 main 66eca746
│  (empty) Merge branch 'XXX' into 'main'

Note that there is an automatically created empty change with my personal email. However, when I create a new change using jj new -m "test" and then do jj log, I see this:

@  lkpwoqkl alex@work.com 2025-02-06 15:17:10 77ceb84b
│  (empty) test
○  rtwzklzt alex@personal.com 2025-02-06 15:16:51 a0cd8d2a
│  (empty) (no description set)
◆  vqqvouzl alex@work.com 2025-02-06 15:09:51 main 66eca746
│  (empty) Merge branch 'XXX' into 'main'

Note that this change was created with my work email as intended.

Expected Behavior

Automatically created empty change should respect [[--scope]] settings.

Actual Behavior

Automatically created empty change ignores [[--scope]] settings.

Specifications

  • Platform: MacOS
  • Version: 0.25.0
@teenjuna
Copy link
Author

teenjuna commented Feb 6, 2025

@yuja may be of interest to you, not really sure

@bnjmnt4n bnjmnt4n closed this as completed Feb 6, 2025
@bnjmnt4n
Copy link
Member

bnjmnt4n commented Feb 6, 2025

This should be fixed in v0.26 (newly released today).

@teenjuna
Copy link
Author

teenjuna commented Feb 6, 2025

Thanks! Sorry for dupe, tried to find this reported but failed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants