-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community plugins #161
Community plugins #161
Conversation
This recipe downloads, installs and enables community plugins.
LGTM. |
Is it possible to write some Chefspec test(s) around this? It seems we are lacking them in this repo. |
@michaelklishin agreed, looks good, but i think we should enforce some chefspec tests from now on :) |
I'll look into it :) |
@dggc i got a start of some chefspec framework here on this branch: https://github.com/jjasghar/rabbitmq/tree/chefspec_update |
@jjasghar on behalf of the RabbitMQ team I'd like to thank you for what you've been doing to the cookbook recently! |
@michaelklishin no problem :) I'll do my best to keep this ship afloat. From now on any change that would like to be added or updated i'm going to mandate a least chefspec tests. I'm going to treat this like the stackforge/opentack-chef cookbooks. |
@jjasghar excellent. I am not very up-to-date with recent developments in Chef but would be happy to help if needed. |
@michaelklishin awesome thanks. Yeah i'm gonna chip away at this slowly but surely. 3.4.0 has been released to supermarket earlier today. |
@dggc if you can just and one spec file like i have for the rest of the recipes I'll go ahead and merge this in. Example: https://github.com/jjasghar/rabbitmq/blob/master/spec/plugin_management_spec.rb I'm saying if you want to do more...i'm ok with that too 👅 |
@jjasghar I added the default spec file for this recipe. I tried to add some more tests for this recipe, but I could not run the specs, they are throwing some error when I try to "rake spec" I'll try to fix my environment here, and maybe add some more tests later on :) |
This pull requests adds a new recipe, rabbitmq::community_plugins, that downloads, installs and enables community plugins.
To specify a plugin, set the attribute
node['rabbitmq']['community_plugins']['PLUGIN_NAME']
to'DOWNLOAD_URL'
. For example, to use the RabbitMQ priority queue plugin (https://github.com/rabbitmq/rabbitmq-priority-queue), set the attributenode['rabbitmq']['community_plugins']['rabbitmq_priority_queue']
to'https://www.rabbitmq.com/community-plugins/v3.4.x/rabbitmq_priority_queue-3.4.x-3431dc1e.ez'
.