Chefspec update #168
Merged
Chefspec update #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 26, 2014 19:25
This is an inital commit of some generic chefspec tests for the rabbitmq cookbook. I've tied it up to the `rake travis` task so when this is merged we can have it run as part of the PR process. Again this is just an example and a start, we can attempt to test the LWRPs at a later date. Comments are more than welcome.
This was referenced Nov 27, 2014
|
|
||
| let(:file_cache_path) { Chef::Config[:file_cache_path] } | ||
|
|
||
| version = '3.3.5' |
There was a problem hiding this comment.
maybe define this at the beginning and use it for node.default['rabbitmq']['version'] to avoid replicated definitions of the version (also this should probably be '3.3.5-1' ?)
I attempted to get the version in object, but i couldn't seem to get it correct. Any advice or suggestions are more than welcome. I'd like to merge this ASAP so I can update to 3.4.2 this week.
|
|
||
| describe 'rabbitmq::default' do | ||
|
|
||
| version = '3.3.5-1' |
There was a problem hiding this comment.
I don't like this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an inital commit of some generic chefspec
tests for the rabbitmq cookbook. I've tied it up to
the
rake travistask so when this is merged we canhave it run as part of the PR process.
Again this is just an example and a start, we can attempt
to test the LWRPs at a later date.
Comments are more than welcome.