NO-REF Check chef client version before calling sensitive

[xiangyao1989]

This PR is aimed to fix the issue which chef-client with a version less than 11.14 complaining about method sensitive missing. My current project requires a chef-client version 11.12 for some reasons, and we can't depend on this rabbitmq cookbook because of the version gap in chef-client.
This fix shouldn't affect any other user but make this cookbook fit into older versions of chef client. We've tested it under chef 11.12 and it works perfect!

Refer to: chef/chef#1744 for more details.
Thanks!

[jjasghar]

I gotta admit this is pretty simple and clever. I'll get this set up for the next release.

[jemc]

Won't comparing as a float cause problems with the minor part when a different number of minor digits is used on each side?

For example, in version numbering, 1.10 should be greater than 1.2, but in float comparisons it it less.

[xiangyao1989]

@jemc Good point!
I think this one will work:

Gem::Version.new('1.10') > Gem::Version.new('1.2')
 => true 

[xiangyao1989]

@jemc I just updated it to be:

sensitive true if Gem::Version.new(Chef::VERSION.to_s) >= Gem::Version.new('11.14.2')

And I made the version more accurate to 11.14.2, which is the version sensitive method introduced.
Thanks for the comment!

[xiangyao1989]

@jjasghar Thanks for your quick response! We're looking forward to this fix~ : >

[jjasghar]

Can you add a test against this also?

[xiangyao1989]

@jjasghar Yep~ Just added one unit test case and verified it works~ Thanks~

[jjasghar]

🤘 awesome thanks @XiangYao, all we need is another +1 from someone else and then we're good to release this.

[michaelklishin]

This looks reasonable.

I'm not familiar enough with Chef client internals or change history to +1, though.