Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COOK-3606] remove trailing \n from erlang cookie file contents #84

Merged
merged 2 commits into from
Sep 21, 2013
Merged

[COOK-3606] remove trailing \n from erlang cookie file contents #84

merged 2 commits into from
Sep 21, 2013

Conversation

portertech
Copy link
Contributor

@sethvargo
Copy link
Contributor

@portertech do you think String#strip is more appropriate here, just in case there's extra spaces (that aren't newlines)?

@portertech
Copy link
Contributor Author

@sethvargo Updated to use strip(). It's unlikely that there will be extra spaces etc, but no reason to not cover our butts 👍

@portertech
Copy link
Contributor Author

@sethvargo 👍 ?

@sethvargo
Copy link
Contributor

👍

mattray pushed a commit that referenced this pull request Sep 21, 2013
Merge pull request #84 from portertech/COOK-3606
5015500 
[COOK-3606] remove trailing \n from erlang cookie file contents
@mattray mattray merged commit 5015500 into rabbitmq:master Sep 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portertech @sethvargo @mattray