Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for m1 macs #52

Closed
seanmacavaney opened this issue Mar 3, 2023 · 6 comments · Fixed by #54
Closed

support for m1 macs #52

seanmacavaney opened this issue Mar 3, 2023 · 6 comments · Fixed by #54

Comments

@seanmacavaney
Copy link

pip install fastrank

Fails on M1 macs. I have a built wheel that you could upload to pypi, if you like.

@jjfiv
Copy link
Owner

jjfiv commented Mar 3, 2023

I'm off next week, so I'll try and get Github to build that variant. If not I'd be glad to have your binary.

@seanmacavaney
Copy link
Author

Awesome, thanks! Feel free to reach out. The trick to getting it to build for me was setting maturin==0.13.7. Perhaps the wheel doesn't need to be distributed directly if this change is made.

@jjfiv
Copy link
Owner

jjfiv commented Mar 25, 2023

@seanmacavaney do you still need Python3.6 support? Seems to have been dropped by github actions, so I'll be dropping it as well.

@jjfiv
Copy link
Owner

jjfiv commented Mar 25, 2023

Going to assume no, from PyPI there's a >=3.7 on PyTerrier.

@jjfiv jjfiv linked a pull request Mar 25, 2023 that will close this issue
@jjfiv jjfiv closed this as completed in #54 Mar 25, 2023
@jjfiv jjfiv reopened this Mar 25, 2023
@jjfiv
Copy link
Owner

jjfiv commented Mar 25, 2023

@seanmacavaney
Copy link
Author

Works perfectly, thanks!

No need on my end for python<=3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants