Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis removes encrypted env variables for external PR #12

Open
dlespiau opened this issue Apr 14, 2019 · 0 comments
Open

Travis removes encrypted env variables for external PR #12

dlespiau opened this issue Apr 14, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@dlespiau
Copy link
Member

The build currently needs NPM_TOKEN defined and that variable is defined in Travis.

I think it's actually quite a pain to have this .npmrc file with an undefined token variable for something that is only used for publishing releases on npm. A thing we could do is to only generate that fine before deploying:

 echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > .npmrc
@dlespiau dlespiau added the bug Something isn't working label Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant