Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action type does not support object as showed in the docs #92

Closed
vinipachecov opened this issue Nov 27, 2019 · 6 comments
Closed

Action type does not support object as showed in the docs #92

vinipachecov opened this issue Nov 27, 2019 · 6 comments
Assignees
@jkeam
Labels
bug

Comments

@vinipachecov
Copy link

The current Action interface supports only string array or null, it does not support receiving objects as stated in the docs.

Captura de Tela 2019-11-27 às 08 55 25

Current type docs
carbon
@jkeam
Copy link
Owner

jkeam commented Dec 3, 2019

Yep, good catch. This should be supported, as you can see in test/createActionsTest.js:46.

@jkeam jkeam added the bug label Dec 3, 2019
@jkeam jkeam self-assigned this Dec 3, 2019
@jkeam jkeam mentioned this issue Dec 3, 2019
Closed
@jkeam jkeam mentioned this issue Dec 22, 2019
Merged
@jkeam
Copy link
Owner

jkeam commented Dec 22, 2019

@vinipachecov and @sayjeyhi I hope this PR #94 fixes your issue.

I think I'll leave the PR open a bit (like a week or so). Let me know if this PR doesn't fix your issue and any/all feedback/comments you have. Thanks again to you both for finding and reporting this!

@vinipachecov
Copy link
Author

@jkeam I'll take a look into it today!

@jkeam
Copy link
Owner

jkeam commented Dec 23, 2019

Thanks so much for the help :)

@vinipachecov
Copy link
Author

@jkeam just replied there.

@jkeam
Copy link
Owner

jkeam commented Jan 19, 2020 •
edited
Loading

Closing this as it has been addressed in #94

Also published as version v1.1.2

@jkeam jkeam closed this as completed Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkeam jkeam

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkeam @vinipachecov