Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generation fails when module's path contains . #151

Closed
mykelalvis opened this issue May 1, 2020 · 1 comment · Fixed by #152
Closed

Generation fails when module's path contains . #151

mykelalvis opened this issue May 1, 2020 · 1 comment · Fixed by #152
Labels
bug
Milestone
5.1.2

Comments

@mykelalvis
Copy link
Contributor

A full text S&R is done on all . elements of a path string. Since jooq passes the value in as a String, this seems right unless the module has a . somewhere in it's parent tree.

PR inbound to fix this.
@mykelalvis mykelalvis mentioned this issue May 1, 2020
Merged
@jklingsporn jklingsporn added the bug label Jul 3, 2020
@jklingsporn
Copy link
Owner

Thank you very much for your contribution ❤️

@jklingsporn jklingsporn added this to the 5.1.2 milestone Jul 3, 2020
@jklingsporn jklingsporn mentioned this issue Jul 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.1.2
Development

Successfully merging a pull request may close this issue.

Fix overly eager replacement of "." with nio.Path changes mykelalvis/vertx-jooq
2 participants
@mykelalvis @jklingsporn