Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder '%svg' is not extended in every class #3

Closed
stefanjudis opened this issue Feb 19, 2014 · 2 comments
Closed

Placeholder '%svg' is not extended in every class #3

stefanjudis opened this issue Feb 19, 2014 · 2 comments
Assignees
Labels

Comments

@stefanjudis
Copy link

Hey Joschi,

sorry for filing so many issues. But I have to file another one...

Grunt task now runs fine, but there is an issue with the generated '.scss' file.

%svg {
    background-image:url(svg/sprite.svg);
    background-repeat:no-repeat
}
.svg-acucar,
.svg-acucar\:regular {
    @extend %svg;
    background-position: 0 0;
}
.svg-acucar-dims {
    width: 70px;
    height: 70px;
}
.svg-conservante,
.svg-conservante\:regular {
    background-position: 0 -70px;
}
.svg-conservante-dims {
    width: 70px;
    height: 70px;
}

only the first class is extending the placeholder.

Thanks.

@jkphl
Copy link
Collaborator

jkphl commented Feb 19, 2014

Hey @stefanjudis,

no need for excuses — you're probably the first one to really test it, so your help is highly appreciated!

Yeah, I remember there has been another related bug before. Maybe I messed it up ... I'll look into this. :)

@jkphl
Copy link
Collaborator

jkphl commented Feb 19, 2014

Ok, the v0.0.7 release of svg-sprite should fix this! :)

This is really crazy! I remember having some serious issues with the @extends at an earlier stage: When converting the .scss files with sass, the %svg block got rendered multiple times (once for each icon!), and I didn't find a reason for this. I changed some stuff (this was probably also the moment when I messed it up ;)) and the strange behaviour was gone (along with the correct output, obviously) ...

Hope it works now! :)

@jkphl jkphl closed this as completed Feb 19, 2014
@jkphl jkphl self-assigned this May 27, 2014
@jkphl jkphl added the bug label May 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants