Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerDependencies #25

Closed
guyellis opened this issue Jun 8, 2015 · 6 comments
Closed

peerDependencies #25

guyellis opened this issue Jun 8, 2015 · 6 comments
Assignees

Comments

@guyellis
Copy link

guyellis commented Jun 8, 2015

npm WARN peerDependencies The peer dependency vinyl@^0.4.6 included from gulp-svg-sprite will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
@jkphl
Copy link
Collaborator

jkphl commented Jun 8, 2015

Hi @guyellis,

thanks for reporting this. Do I understand this right that all I need to "fix" this is list vinyl as a regular dependency? (Guess this holds true for all peerDependencies in the future?)

Cheers,
Joschi

@jkphl jkphl self-assigned this Jun 8, 2015
@guyellis
Copy link
Author

guyellis commented Jun 8, 2015

@jkphl Yes - I believe that's the case.

@shaneparsons
Copy link

Until there's a fix, what do I have to do from my end to be able to use gulp-svg-sprite?

@jkphl
Copy link
Collaborator

jkphl commented Jun 17, 2015

@shaneparsons Two things:

  • The "fix" is already commited to this repo. If you want to, just replace your package.json with the most recent one in this repo.
  • As far as I understood, all this is just a warning about the future deprecation of a feature in npm@3. It should not be a show-stopper of any kind. There is no urgent need to do anything.

However, I will try to push out new releases soon, so you might also just wait and update later today.

@shaneparsons
Copy link

ah okay good to know, thanks for clearing that up!

@jkphl
Copy link
Collaborator

jkphl commented Jun 17, 2015

Fixed as of release v1.2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants