-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow git remote repository file #50
Comments
Looking at the helm documentation, helm supports multiple method to get an value file
helm-secret should also support that to be consistent with helm. I don't know howto get files through helm via 3rd party plugin outside helm, but http could be done nativly. Getting remote files other the 3 method provided by helm are out of scope. Most of the git repositories are accessable via http rest api, if you are using some UI for git projects. I close this now, since I understand this issue is talking about get value files via git command. |
@jBouyoud combined with https://github.com/aslafy-z/helm-git this could your solution then. |
I don't catch that in the doc. |
Yes, It's not documented. I add this functionality in helm-secrets, too. See: #52 |
See it here in action now: helm-secrets/tests/unit/template.bats Line 263 in 0c5b62d
|
Very nice 💪 , thanks you |
Hello,
This is about a new feature :
This issue should be about how to implement it.
I'll see the following options:
Not here
This is not the purpose of this plugin. Let's create a specific one, or your specific driver....
Pros
Cons
Add a new kind of driver to be able to retrieve file from a location
Introduce a new kind of driver. Interface could be something like
is_supported $1
;get_content $1
Pros
Cons
As a new driver
Build a new
sops_git
driverPros
Cons
driver_is_supported_file
, and replace all[ -f ... ]
I'll be glad to create a PR on that subject, please let me know.
The text was updated successfully, but these errors were encountered: