Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate into compute-incrdatespace #7

Closed
dy opened this issue Aug 14, 2017 · 2 comments
Closed

Integrate into compute-incrdatespace #7

dy opened this issue Aug 14, 2017 · 2 comments

Comments

@dy
Copy link
Collaborator

dy commented Aug 14, 2017

Here is awesome package using the same functionality: https://github.com/compute-io/incrdatespace

I think it would be winning for both to cross-test cases and make integration.

The cases:

  • ms, millisecond, milliseconds
  • s, sec, secs, second, seconds
  • m, min, mins, minute, minutes
  • h, hr, hrs, hour, hours
  • d, day, days
  • w, wk, wks, week, weeks
  • b, month, months
  • y, yr, yrs, year, years

Anyways there is no tests, so mb worth adding.
Just for note.

cc @kgryte is there any sense in that?

@jkroso
Copy link
Owner

jkroso commented Aug 14, 2017

The Readme used to be runnable and served as the test suite. Not sure if that still works. Anyway feel free to add tests!

@dy
Copy link
Collaborator Author

dy commented Apr 22, 2020

Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants