Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh colors is incorrect #22

Open
rmccampbell opened this issue Mar 15, 2022 · 2 comments
Open

Mesh colors is incorrect #22

rmccampbell opened this issue Mar 15, 2022 · 2 comments

Comments

@rmccampbell
Copy link

I think your definition of colors on the Mesh type is incorrect, it should be a vec of vecs, like texture_coords. Also I believe the texture coords, while it technically works, can be made a Vec<Vec<Vector3D>> instead of Vec<Option<Vec<Vector3D>>>. As far as I can tell both mTextureCoords and mColors on aiMesh are defined to end at the first null pointer, so basically you can just discard any null pointer and the rest of the array.

@jkvargas
Copy link
Owner

Hey mate, thanks for the tip.
I'll double check it between today and tomorrow and I'll come back to you.
😁

@jkvargas
Copy link
Owner

Hey bud, sorry for the very late response.
I believe you are correct.
I was trying to get confirmation on assimp/assimp#4460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants