Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify default subtitle language #118

Open
ianjsikes opened this issue Jan 5, 2021 · 1 comment
Open

Add option to specify default subtitle language #118

ianjsikes opened this issue Jan 5, 2021 · 1 comment
Labels

Comments

@ianjsikes
Copy link

Many of the subtitle files I try to process are skipped because "subtitle language can't be detected". It would be nice to have an option to specify a fallback language in these cases.

Example of a file that isn't processed:

Soul.2020.720p.WEBRip.800MB.x264-GalaxyRG.srt

I thought this would be the behavior of the --language flag. Maybe it warrants a new option to avoid changing the default behavior.

@jkwill87
Copy link
Owner

jkwill87 commented Jan 6, 2021

I thought this would be the behavior of the --language flag. Maybe it warrants a new option to avoid changing the default behavior.

Given that the main use case for subtitles is to watch media in another language than it was dubbed, subtitles files typically don't match their accompanying media files. Also, multiple subtitle files are included with a given release. My concern is that if language or some other config setting applied to subtitles it would be too easy to misattribute the language or overwrite files when running mnamer on a directory or recursively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants