Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationExperimental has been removed #10

Open
Rhyzko opened this issue May 8, 2017 · 8 comments
Open

NavigationExperimental has been removed #10

Rhyzko opened this issue May 8, 2017 · 8 comments

Comments

@Rhyzko
Copy link

Rhyzko commented May 8, 2017

Hello Jon,

(first of all, thanks a lot for your videos, I've learned a lot).
I'm currently following your "Getting Started with React Native and Redux" videos. (Step 10)
NavigationExperimental has been removed 8 days ago. (facebook/react-native@febf3d0)

Have you planned to fix this problem by replacing the navigation example ?

Meanwhile I'll try to find out other way to implement the tab navigation functionnality.

Thanks by advance,

Regards.

@jlebensold
Copy link
Owner

Hi @Rhyzko thanks for the feedback. As you mentioned, NavigationExperimental has been removed and replaced by React Navigation. I have another reference project here that includes it:
https://github.com/paradem/oscon-2017

@jqn
Copy link

jqn commented Jun 9, 2017

Hi @jlebensold the oscon repo is a great example for StacksOverTabs. I was wondering though if you had any pointers on how to convert this is StacksInTabs. I tried and keep running into this error:
Expect nav state to have routes and index, {"routeName":"Main","key":"Init"}

@jlebensold
Copy link
Owner

@jqn can you provide a gist or a fork of what you're doing? I think each of the Nav components may require a slightly different data shape to function correctly.

@jqn
Copy link

jqn commented Jun 20, 2017

@jlebensold thanks for your quick answer. I apologize it took me a while to get back to this issue. I have a fork here https://github.com/jqn/StacksInTabsReduxExample. I appreciate your help, thanks.

@whatya
Copy link

whatya commented Jun 26, 2017

@jlebensold project build error:
Command failed: /usr/libexec/PlistBuddy -c Print:CFBundleIdentifier build/Build/Products/Debug-iphonesimulator/peckish.app/Info.plist
Print: Entry, ":CFBundleIdentifier", Does Not Exist

@jlebensold
Copy link
Owner

Hi @whatya this probably has to do with your own bundle configuration in XCode.

@jqn
Copy link

jqn commented Jul 14, 2017

Thanks for the help @jlebensold, I managed to get stacksintabs working correctly and I will add a link to this repo once I clean it up if anyone else needs and example of this working with redux and react-navigation

@jqn
Copy link

jqn commented Dec 8, 2017

Like I promised here are some examples of react navigation integration with redux
https://github.com/jqn/react-navigation-redux-examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants