Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DownloadsDocument #839

Open
chelid opened this issue Dec 31, 2024 · 2 comments
Open

DownloadsDocument #839

chelid opened this issue Dec 31, 2024 · 2 comments

Comments

@chelid
Copy link

chelid commented Dec 31, 2024

Hi,

On src/Traits/DownloadsDocument.php - we can't define our own GuzzleHttp Client.
Can you please fix it?

In addition, src/Seller/DataKioskV20231115/Responses/GetDocumentResponse.php doesn't use the DownloadsDocument trait. Is that on purpose?

Thanks
@chelid
Copy link
Author

chelid commented Jan 6, 2025

Same issue on src/Traits/UploadsDocument.php - we can't define our own GuzzleHttp Client.

@jlevers
Copy link
Owner

jlevers commented Feb 16, 2025

You can now define custom a Guzzle client for both uploading and downloading documents (see README for more details).

The GetDocumentResponse DTO format is somewhat different from the feed/report document DTO, and I don't know that I'll get around to updating the DownloadsDocument trait anytime soon to work with GetDocumentResponse. I'd welcome a PR – contributing docs here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlevers @chelid