Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change step function conditionals to not reference pageYOffset #12

Open
jljorgenson18 opened this issue Apr 19, 2017 · 0 comments
Open

Comments

@jljorgenson18
Copy link
Owner

Referencing pageYOffset requires layout calculations (https://gist.github.com/paulirish/5d52fb081b3570c81e3a). A better approach would be to see how close the result of the easing function is close to '1.' We can add a percentage buffer to handle rounding errors which should stop the need to reference pageYOffset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant