Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action fails when not triggered by pull_request #11

Closed
jlndk opened this issue Feb 2, 2021 · 0 comments · Fixed by #136
Closed

Action fails when not triggered by pull_request #11

jlndk opened this issue Feb 2, 2021 · 0 comments · Fixed by #136

Comments

@jlndk
Copy link
Owner

jlndk commented Feb 2, 2021 •
edited
Loading

Currently the action fails if it is run by other triggers than pull_request, as seen here https://github.com/jlndk/github-action-jest/runs/1813941419?check_suite_focus=true.

This happens because it always tries to get the issue number from the context.

github-action-jest/src/comment.ts

Line 14 in e3cc35d

issue_number: context.payload.number,

We should either not attempt to post the comment if issue_number is not available on the context, or throw a more user-friendly warning instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make this action work on "non-pr" events (on push) jlndk/github-action-jest
1 participant
@jlndk