Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new animation types configuration setting #315

Open
jmakhack opened this issue Oct 10, 2022 · 2 comments
Open

Add new animation types configuration setting #315

jmakhack opened this issue Oct 10, 2022 · 2 comments
Labels
enhancement New feature or request hacktoberfest This issue qualifies for the hacktoberfest event help wanted Extra attention is needed java Pull requests that update Java code up for grabs Any issue that is up for grabs
Milestone

Comments

@jmakhack
Copy link
Owner

jmakhack commented Oct 10, 2022

Feature Reasoning

A new feature being introduced in v2.0.0 is the hydrate animation feature. Right now, there is only the option to enable/disable the animation setting. It would be nice to also have the ability to set which animation gets played on every hydrate interval.

Feature Description

Add a new configuration option Animation type which contains a dropdown of animation options. For a temporary second option, AnimationID.COOKING_WINE can be used for now.

For this feature, it would be good to create a new enum HydrateReminderAnimations similar to HydrateReminderTimerImages as well. Other new classes may need to be created as well such as a handler/provider class.

Additional Context

Please refer to CONTRIBUTING.md for info on how to setup, build, run, and test this project.

@jmakhack jmakhack added enhancement New feature or request help wanted Extra attention is needed java Pull requests that update Java code hacktoberfest This issue qualifies for the hacktoberfest event up for grabs Any issue that is up for grabs labels Oct 10, 2022
@jmakhack jmakhack added this to the v2.0.0 milestone Oct 10, 2022
@ArshErgon
Copy link
Contributor

can I work on this?
and can you tell which do I need to add all this? HydrateReminderConfig.java? and the enum for hydrateReminderTimerImages doesn't exists. I couldn't find it.

@jmakhack
Copy link
Owner Author

@ArshErgon go for it! The timer images enum got recently refactored into the images package. The end result of this feature work should be a new dropdown option in the Animation settings section. It should be similar to the timer images dropdown but for animations instead of images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest This issue qualifies for the hacktoberfest event help wanted Extra attention is needed java Pull requests that update Java code up for grabs Any issue that is up for grabs
Projects
None yet
Development

No branches or pull requests

2 participants