forked from ccache/ccache
-
Notifications
You must be signed in to change notification settings - Fork 2
/
HACKING.txt
59 lines (46 loc) · 2.01 KB
/
HACKING.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
Hacking ccache
==============
Code formatting
---------------
* Use tabs for indenting and spaces for aligning C code. See
<http://www.emacswiki.org/emacs/SmartTabs>.
* Use 4 spaces for indenting other code (and spaces for aligning).
* Put the opening curly brace on a new line when defining a function, otherwise
at the end of the same row.
* Put no space between function name and the following parenthesis.
* Put one space between if/switch/for/while/do and opening curly brace.
* If possible, keep lines at most 80 character wide for a 2 character tab
width.
* Use only lowercase names for functions and variables.
* Use only uppercase names for enum items and (with some exceptions) macros.
* Don't use typedefs for structs and enums.
Idioms
------
* Use NULL to initialize null pointers.
* Don't use NULL when comparing pointers.
* Use format(), x_malloc() and friends instead of checking for memory
allocation failure explicitly.
* Use str_eq() instead of strcmp() when testing for string (in)equality.
* Consider using str_startswith() instead of strncmp().
* Use bool, true and false for boolean values.
* Use tmp_unlink() or x_unlink() instead of unlink().
* Use x_rename() instead of rename().
Other
-----
* Strive to minimize use of global variables.
* Write test cases for new code.
Commit messages
---------------
* Write a short description on the first line. If wanted, leave the second line
empty and write a longer description on line three and below.
* Start the short description with a capital letter. Optional: prefix the short
description with a context follow by a colon.
* The short description should be in "command form" (see examples below).
* Don't put a final period after the short description.
* Keep lines in the message at most 75 characters wide.
Example 1:
Hash a delimiter string between parts to separate them
Previously, "gcc -I-O2 -c file.c" and "gcc -I -O2 -c file.c" would hash to
the same sum.
Example 2:
win32: Add a space between filename and error string in x_fmmap()