Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify replicas for deployment #48

Open
awalther52 opened this issue Dec 6, 2023 · 1 comment
Open

Add ability to specify replicas for deployment #48

awalther52 opened this issue Dec 6, 2023 · 1 comment

Comments

@awalther52
Copy link

For availability reasons, it would be ideal to have more than one replica when running as a deployment. Right now replicas is hardcoded to one. If the node the pod is running on goes down, we loose this metric until the pod is rescheduled onto another node.

Is there a reason why this was not added from the start?

I'd be happy to put up a PR for the helm chart edits!

@jmcgrath207
Copy link
Owner

jmcgrath207 commented Dec 6, 2023

Sounds great to me! No reason ATM. I am open to a PR for this with a default of one replica.

If this doesn't work as intended for you, then we will have to look into the leader election at the Golang level.

https://github.com/kubernetes/client-go/blob/master/examples/leader-election/main.go#L122

@jmcgrath207 jmcgrath207 self-assigned this Dec 7, 2023
@jmcgrath207 jmcgrath207 removed their assignment Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants