Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 15 introduced unintended pointer vs value return changes #20

Closed
jasdel opened this issue Feb 2, 2016 · 1 comment
Closed

PR 15 introduced unintended pointer vs value return changes #20

jasdel opened this issue Feb 2, 2016 · 1 comment

Comments

@jasdel
Copy link
Contributor

jasdel commented Feb 2, 2016

In #15 it looks like some unintended changes where introduced. I scalar types are not being returned as values types even if the field for that value was a pointer type. Structs still are being returned as pointer types if they originally were.

This issue was reported to us in aws/aws-sdk-go#535 as it is breaking some functionality for those not using vendoring with the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants