Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jmespath.spec? #1

Closed
mtdowling opened this issue Nov 6, 2014 · 4 comments
Closed

jmespath.spec? #1

mtdowling opened this issue Nov 6, 2014 · 4 comments

Comments

@mtdowling
Copy link
Contributor

It's hard right now to submit a proposed change to jmespath because I need to send a PR to jmespath.test then one to boto/jmespath. I suggest moving the spec, docs, and test cases to jmespath.spec (or something similar) so that language proposals, new functions, etc can be managed in a single place.

@mtdowling
Copy link
Contributor Author

I think making a jmespath/jmespath repo that combines jmespath.test and jmespath.site would be great to help contributors be able to more easily add test cases, documentation, and proposals in a single PR. What do you think, @jamesls?

@jamesls
Copy link
Member

jamesls commented Jan 21, 2016

I'd be interested in having a repo that contains just the proposals, and maybe the spec as well.

I'd like to make it easier for people to propose ideas, and not necessarily require them to have to update the specification or add test cases.

I've seen that languages such as go and rust have repos just for proposals, I'm wondering if maybe a jmespath.jep makes sense here. What's most important is the proposal and the discussion around the proposal. Once it's been approved, in theory anyone can update the spec or add test cases (though it's great if the proposer also wants to take on that work). Otherwise, it's potentially wasted effort if a user updates the spec and add tests for a proposal that's rejected.

What do you think?

@mtdowling
Copy link
Contributor Author

Sure that sounds good. When I submit JEPs, I could just open two separate pull requests if needed -- one for the spec and one for the tests.

@jamesls
Copy link
Member

jamesls commented Mar 24, 2023

Closing out old issue, there's now a jmespath.jep repo for new language features, where tests are added directly to the JEP.

@jamesls jamesls closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants