Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Learnable modules in ddgm example #6

Open
psmaragdis opened this issue Oct 18, 2023 · 0 comments
Open

Learnable modules in ddgm example #6

psmaragdis opened this issue Oct 18, 2023 · 0 comments

Comments

@psmaragdis
Copy link

In the ddgm example shouldn't the line:

self.p_dnns = p_dnns

be:

self.p_dnns = nn.ModuleList( p_dnns)

My understanding is that by not placing them in a ModuleList the p_dnns networks are not added in the learned parameters and are left unoptimized.

Thanks for an awesome resource by the way!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@psmaragdis