Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated with the new react native version #28

Open
vadermemo opened this issue Jul 10, 2018 · 8 comments
Open

Deprecated with the new react native version #28

vadermemo opened this issue Jul 10, 2018 · 8 comments

Comments

@vadermemo
Copy link

This amazing project is deprecated with the new react native version

@fabriziogiordano
Copy link

what do you mean by deprecated with the new react native version?

@vadermemo
Copy link
Author

Hi bro, try to create a new project with the react native last current version and you will see that have a lots of errors.

@MarianBe
Copy link

same,
image

@iamacup
Copy link

iamacup commented Jul 23, 2018

@jmurzy @fabriziogiordano @padampadam @vadermemo the problem is that NPM fetches a version (tagged as v1.1.1) that does NOT match the latest release on github - the specific issue is that the version that comes back from NPM relies on a removed import

import` React, {
  Component,
  PropTypes,
} from 'react';

I am not sure how this has happened, but basically if you can replicate it with the following steps:

npm init
npm i --save react-native-foldview

then go to node_modules/react-native-foldview/src/FoldView.js and you will see the file does NOT match latest on github and is totally broken on latest react version because of the PropTypes spin out.

or download the file that NPM is serving directly here - https://registry.npmjs.org/react-native-foldview/-/react-native-foldview-1.1.1.tgz

@iamacup
Copy link

iamacup commented Jul 23, 2018

If you do

npm i --save https://github.com/jmurzy/react-native-foldview

you end up with the correct version, it is really wierd.

@jmurzy
Copy link
Owner

jmurzy commented Jul 28, 2018

Just released master as v1.2.1. Can you check if that fixes your issue?

Also, we probably need to refactor things a little to make it compatible with the latest React Native. If anyone's willing to work on this, please feel free to send a pull request. Thanks.

@fabriziogiordano
Copy link

@jmurzy I am happy to help. Tho I am not an expert and I will really appreciate if you can give a couple of area you suggest to focus the efforts.

@ghost
Copy link

ghost commented Apr 11, 2019

It works well with these dependencies.
"dependencies": {
"lodash": "^4.17.11",
"moment": "^2.24.0",
"prop-types": "^15.7.2",
"react": "16.8.3",
"react-moment": "^0.8.4",
"react-native": "0.59.2",
"react-native-animatable": "^1.3.2",
"react-native-elements": "^1.1.0",
"react-native-foldview": "^1.2.1",
"react-native-image-picker": "^0.28.1",
"react-native-linear-gradient": "^2.5.4",
"react-native-navigation": "^2.17.0",
"react-native-splash-screen": "^3.2.0",
"react-native-vector-icons": "^6.4.2"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants