Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] API for OctoDash #405

Closed
hawkeyexp opened this issue Mar 11, 2021 · 6 comments
Closed

[FR] API for OctoDash #405

hawkeyexp opened this issue Mar 11, 2021 · 6 comments

Comments

@hawkeyexp
Copy link

Hi, i was asking for support of G29 (showing info while leveling is running and possible the results) and the dev told me it is hard for him cause octoprint is not aware of the current code.
Your plugin does this trick :-) Would it be possible to release a simple access for octodash to catch the informations like start of leveling end of leveling and results - possible also the heatmap ?

Here is the irginal issue for octodash:

UnchartedBull/OctoDash#1531

Thx

@jneilliii
Copy link
Owner

Interestingly enough I think my BLVLogger plugin might work in this situation if @UnchartedBull just needs an API endpoint to query. It's a little convoluted but it assumes a start and end date to pull a list of historical meshes.

I know that he is already in the process of converting over to websockets for communicating with OctoPrint and when that happens he can actually listen in on the data that my plugin is sending back to the front end natively here without this additional step.

@UnchartedBull
Copy link

That is great news! The websocket transition is going really well so far. Only Job Progress and Z-Height left 🤞 . I guess this issue can be closed then and I would come back to the original OctoDash issue once v3 is released.

Thanks for all your work on the various plugins! :)

@jneilliii
Copy link
Owner

Thank you for OctoDash, I thoroughly enjoy it. Was going to potentially submit a PR to duplicate the TPLinkSmartplug setup for my Tasmota plugin since they are nearly identical for API calls, would just require a little bit of copying/tweaking.

@jneilliii
Copy link
Owner

Oh, and BTW a lot of plugin utilize that send plugin message method, so you might be able to integrate a lot of plugin related information once that transition to websocket is complete (ie Tasmota on/off status).

@UnchartedBull
Copy link

The PSU Extension should be even simpler once UnchartedBull/OctoDash#1438 is merged. Only requires a single function without an additional service from now on. https://github.com/UnchartedBull/OctoDash/blob/feature/websocket/src/app/services/enclosure/enclosure.octoprint.service.ts#L77 those are the releavant lines :)

@jneilliii
Copy link
Owner

Interesting, you're putting all those inside an enclosure service. That does look like it will be easier to implement. I'll base my Tasmota changes on that branch if that's where you are headed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants