Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugged send file function #47

Open
mat4444 opened this issue Aug 30, 2021 · 1 comment
Open

Bugged send file function #47

mat4444 opened this issue Aug 30, 2021 · 1 comment

Comments

@mat4444
Copy link

mat4444 commented Aug 30, 2021

Hello,
The "send files to your device" function does not work as expected when the receiving device is on another network.
Join desktop tries to upload the files to Google Drive forever, but the file is never received. Here are the errors on the console:

command.js:619 Error: No file Id to share
    at Function.errorPromise (util.js:324)
    at getShareUrlAndData (googledrive.js:200)
    at async Promise.all (/C:/Users/home/AppData/Local/com/app-1.1.2/resources/app.asar/index 0)
    at async DeviceAndroidPhone.uploadFilesGoogleDrive (device.js:209)
    at async Devices.uploadFiles (device.js:166)
    at async DeviceAndroidPhone.uploadFiles (device.js:223)
    at async CommandUploadFiles.customizePush (command.js:614)
    at async CommandUploadFiles.executeSpecific (command.js:123)
    at async HTMLDivElement.commandRender.onclick (controlcommand.js:54)

This issue does not exist when both devices are on the same network.

Additionally, drag'n'drop works to send a local file works fine, even when the two devices are on different networks. The issue is only when using the function on the device list page.

@joaomgcd
Copy link
Owner

Hi. Sorry for the delay. Does it work with the latest version? Does it work if you drag and drop a file on to the device instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants