Receiving Files in jobbr-server should be completely async (migrated)

[michaelschnyder]

originally filed by @michaelschnyder on Apr 4, 2015 on the old repo

---

The jobbr server receives multiple files as multipart data.

See: https://github.com/jobbrIO/jobbr-execution-forked/blob/develop/source/Jobbr.Server.ForkedExecution/BackChannel/ForkedExecutionController.cs#L97

IEnumerable<HttpContent> parts = this.Request.Content.ReadAsMultipartAsync().Result.Contents;

The implementation is not straight forward and should be refactored to used async. Because it can block under certain situations.

• http://stackoverflow.com/questions/15201255/request-content-readasmultipartasync-never-returns
• http://forums.asp.net/t/1836953.aspx?ReadAsMultipartAsync+Breaks+with+Release

It should be something like

public async Task<IHttpActionResult> AddArtefact(long jobRunId) 
{ 
    var streamProvider = await this.Request.Content.ReadAsMultipartAsync(); 
    foreach (var file in streamProvider.Contents) 
    { 
        var content = await file.ReadAsByteArrayAsync(); 
        /* Your Code here */ 
    } 
    return this.Ok(); 
}