fix: ensure nbRows <= nbColumns

Author: jobo322

src/__tests__/test.ts

@@ -27,8 +27,8 @@ describe('linear sum problem', () => {
     const { columnAssignments, rowAssignments } = linearSumAssignment(diff, {
       maximaze: false,
     });
-    expect(columnAssignments).toMatchCloseTo([2, 0, 1, 3, 4]);
-    expect(rowAssignments).toMatchCloseTo([1, 2, 0, 3, 4, -1]);
+    expect(columnAssignments).toMatchCloseTo([1, 2, 0, 3, 4, -1]);
+    expect(rowAssignments).toMatchCloseTo([2, 0, 1, 3, 4]);
   });
   it('differents size: rows < columns', () => {
     const a = [3.1, 1.1, 1.9, 3.99, 5.2];
@@ -42,4 +42,16 @@ describe('linear sum problem', () => {
     expect(columnAssignments).toMatchCloseTo([1, 2, 0, 3, 4, -1]);
     expect(rowAssignments).toMatchCloseTo([2, 0, 1, 3, 4]);
   });
+  it('before failing case', () => {
+    const diff = [
+      [0.10000000000000009, 0.5, 0.6000000000000001, 1.1],
+      [0.3999999999999999, 0, 0.10000000000000009, 0.6000000000000001],
+      [0.8999999999999999, 0.5, 0.3999999999999999, 0.10000000000000009],
+    ];
+    const { columnAssignments, rowAssignments } = linearSumAssignment(diff, {
+      maximaze: false,
+    });
+    expect(columnAssignments).toMatchCloseTo([0, 1, 2, -1]);
+    expect(rowAssignments).toMatchCloseTo([0, 1, 2]);
+  });
 });

src/getShortestPath.ts

@@ -35,7 +35,6 @@ export function getShortestPath(options: GetShortestPathOptions) {
   let delta = 0;
   let curColumn = currUnAssCol;
   let shortestPathCost = getArrayOfInfinity(nbRows);
-
   while (sink === -1) {
     scannedColumns[curColumn] = 1;
     let minVal = Number.POSITIVE_INFINITY;

src/index.ts

@@ -8,15 +8,15 @@ interface Options {
 }
 
 export default function linearSumAssignment(
-  input: DoubleArray[],
+  input: DoubleArray[] | Matrix,
   options: Options = {},
 ) {
   const { maximaze = true } = options;
 
   let matrix = Matrix.checkMatrix(input);
 
   let didFlip = false;
-  if (matrix.columns > matrix.rows) {
+  if (matrix.columns < matrix.rows) {
     didFlip = true;
     matrix = matrix.transpose();
   }
@@ -42,20 +42,20 @@ export default function linearSumAssignment(
       rowAssignments,
       columnAssignments,
     });
-
     let { sink, pred } = currentAugmenting;
 
     if (sink === -1) {
       return {
-        rowAssignments: [],
-        columnAssignments: [],
+        rowAssignments,
+        columnAssignments,
         gain: -1,
+        dualVariableForColumns,
+        dualVariableForRows,
       };
     }
 
     dualVariableForColumns = currentAugmenting.dualVariableForColumns;
     dualVariableForRows = currentAugmenting.dualVariableForRows;
-
     let j = sink;
     for (let i = pred[j]; true; i = pred[j]) {
       rowAssignments[j] = i;