Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken images with <pictures> tag #696

Closed
jocmp opened this issue Jan 7, 2025 Discussed in #692 · 5 comments
Closed

Broken images with <pictures> tag #696

jocmp opened this issue Jan 7, 2025 Discussed in #692 · 5 comments
Assignees
Labels
bug Something isn't working freshrss

Comments

@jocmp
Copy link
Owner

jocmp commented Jan 7, 2025

Discussed in #692

Originally posted by Offerel January 7, 2025
Im using FreshRSS as backend. When i try to read some articles, i miss the pictures in this article. The pictures are displayed, when i click the icon for broken pictures and also, when i switch to the browser view, but not in the reader view.

If i look in to the html source in FreshRSS, this is the case for images with tag. Im not sure, if this is the real issue, but i assume so.

image
image

@jocmp jocmp added bug Something isn't working investigate labels Jan 7, 2025
@jocmp jocmp added this to Capy Reader Jan 8, 2025
@jocmp jocmp moved this to In Progress in Capy Reader Jan 8, 2025
@jocmp jocmp moved this from In Progress to On Deck in Capy Reader Jan 8, 2025
@jocmp jocmp self-assigned this Jan 8, 2025
@Offerel
Copy link
Contributor

Offerel commented Jan 8, 2025

Hi there. First of all, I would like to say thank you. I didn't have the app on my radar before, probably because FreshRSS support was only recently added. But I have to say, the app has almost immediately become my no.1 app for RSS. It's really fast and has almost all the features I use. And your support is mega. Great! Many thanks for that.

What I could also think of regarding this issue: I use the image proxy plugin for FreshRSS. If I understand correctly, the image is loaded into the proxy's cache when the article is accessed via ActivityPub ( i have to ask Alexx, if this is correct). I could imagine that it was not yet there when Capy Reader loaded the article. Can I somehow force it to load the article again later when I am sure that the images have also been cached?

@jocmp
Copy link
Owner Author

jocmp commented Jan 10, 2025

Hey @Offerel. I set up the ImageProxy on an instance of FreshRSS with the same configuration that you mentioned in FreshRSS/Extensions#268 (pic below). I wasn't able to reproduce this problem on the Android Central feed (link).

Which version of the app are you on? I can see if it's version specific. Any luck on your end with further testing? Lastly, does this affect just Android Central or consistently with some feeds?

Config

Screenshot 2025-01-09 at 10 07 45 PM

Working Demo

@jocmp jocmp moved this from In Progress to Parking Lot in Capy Reader Jan 10, 2025
@Offerel
Copy link
Contributor

Offerel commented Jan 10, 2025

Currently its only on the Android Central feed. I have nearby 200 other feeds in my FreshRSS, but no one with this special problem. I have found that other images in an articles from Android Central are displayed fine. It seems to be only the "first image" or "teaser image", or what this is called.

On the other hand, it may also be due to how I extract this feed. I try to remove advertising and unwanted items and use various CSS selectors for this:
image

I'll look at it again today, maybe I'm removing too much or the wrong elements. If I look at your screenshots, this could be the reason.

@Offerel
Copy link
Contributor

Offerel commented Jan 10, 2025

I can confirm, without the filtering and CSS selectors, its working and no broken pictures are visible in Capy Reader.

Now I have to choose a better filter for this feed. But from my point of view, we can close this issue. For some reason, I can't from my side.

@jocmp
Copy link
Owner Author

jocmp commented Jan 10, 2025

sounds good!

@jocmp jocmp closed this as completed Jan 10, 2025
@github-project-automation github-project-automation bot moved this from Parking Lot to Done in Capy Reader Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working freshrss
Projects
Archived in project
Development

No branches or pull requests

2 participants