Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some feed icons not shown in Capy Reader, but they do appear in FreshRSS #754

Closed
silentcreek opened this issue Jan 20, 2025 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@silentcreek
Copy link

Steps to Reproduce

I have a FreshRSS server off of which I read feeds with Capy Reader using the GReader API. There are some feeds that will show a favicon on the FreshRSS webinterface, but don't in Capy Reader. Instead, I see a generic black and white RSS icon for all of them.

Examples for such feeds are:
https://github.com/nextcloud/server/releases.atom
https://www.faz.net/rss/aktuell/

Is there a way to change/fix this?

Expected behavior

I would have expected that Capy Reader shows the same icons as FreshRSS.

Screenshots or screen recording

No response

Device, Operating system, and app version

Google Pixel 6a, Android 15, app version 2025.01.1095

@silentcreek silentcreek added the bug Something isn't working label Jan 20, 2025
@jocmp jocmp moved this to On Deck in Capy Reader Jan 21, 2025
@jocmp jocmp moved this from On Deck to In Progress in Capy Reader Jan 22, 2025
@jocmp
Copy link
Owner

jocmp commented Jan 22, 2025

Hey @silentcreek. Thanks for the details here. It turns out Capy wasn't parsing SVG images, and both favicon examples are SVGs.

I added SVG support in the latest version today, 2025.01.1097. This fixed the GitHub feed but not faz.net. Faz.net uses some specific formatting doesn't work with the underlying library. I have an open issue with the library to fix that (coil-kt/coil#2798).

If that doesn't work, I'll see if FreshRSS is open to changing which images they send via the API which would be the ideal fix. Stay tuned!

@jocmp jocmp moved this from In Progress to Parking Lot in Capy Reader Jan 22, 2025
@silentcreek
Copy link
Author

Thanks, version 2025.01.1097 landed on my phone a few days ago and it indeed fixed the GitHub icon. In the meantime, I've worked around the remaining Faz.net icon issue by removing the media query in the cached icon on the FreshRSS instance so it is also displayed on my phone in Capy Reader.

@jocmp
Copy link
Owner

jocmp commented Jan 30, 2025

Sounds good. Unfortunately it's a "won't fix" for the underlying library. So if there's a fix on FreshRSS for svgs with unsupported styling like faz.net, that's the best path forward.

Please let me know if you run into any other sites with unsupported favicons and I'll investigate more!

@jocmp jocmp closed this as completed Jan 30, 2025
@github-project-automation github-project-automation bot moved this from Parking Lot to Done in Capy Reader Jan 30, 2025
@jocmp jocmp self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants