Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Changing to dark theme after the creation of a picker does not update the bottom preview #247

Closed
Justsnoopy30 opened this issue Oct 26, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@Justsnoopy30
Copy link
Contributor

It only seems to happen when switching from light theme to dark, and only when calling updateOptions after the picker has been created. See below for screenshot:
Screenshot from 2022-10-25 20-31-15

@joeattardi joeattardi added the bug Something isn't working label Oct 26, 2022
@joeattardi
Copy link
Owner

Seems to only affect popup pickers, interesting.

@joeattardi joeattardi self-assigned this Oct 26, 2022
@joeattardi
Copy link
Owner

Just published 5.7.2 which hopefully will resolve this for you, please reopen if you still have issues!

@Justsnoopy30
Copy link
Contributor Author

Justsnoopy30 commented Oct 26, 2022

Still seems a bit off, but it's closer. The preview is incorrect (it should be gray but it's black) and there are white pixels around the border of the emoji picker if you look closely.
Nevermind see last comment

Created with dark theme:
image

Switched to dark theme after creation:
image

@Justsnoopy30
Copy link
Contributor Author

There is no button for me to reopen the issue @joeattardi
image

@Justsnoopy30
Copy link
Contributor Author

Ah nevermind maybe it wasn't fully updated or something, can't replicate it again. Also realized it's supposed to be black at the bottom after comparing with the demo on the site. Thanks.

@Justsnoopy30
Copy link
Contributor Author

Justsnoopy30 commented Oct 27, 2022

Minor nitpick, it still shows small white pixels around the edges when I switch to dark from light, and vice versa. Can reproduce that every time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants