Skip to content

Commit 398f1d8

Browse files
elicwhitefacebook-github-bot
authored andcommitted
vars -> let/const react-native IntegrationTests
Reviewed By: yungsters Differential Revision: D7986752 fbshipit-source-id: 1f9b129ce19e052584a2cd1240686b6099c64416
1 parent 75ad71e commit 398f1d8

18 files changed

+143
-140
lines changed

IntegrationTests/AppEventsTest.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,14 @@
1010

1111
'use strict';
1212

13-
var React = require('react');
14-
var ReactNative = require('react-native');
15-
var {NativeAppEventEmitter, StyleSheet, Text, View} = ReactNative;
16-
var {TestModule} = ReactNative.NativeModules;
13+
const React = require('react');
14+
const ReactNative = require('react-native');
15+
const {NativeAppEventEmitter, StyleSheet, Text, View} = ReactNative;
16+
const {TestModule} = ReactNative.NativeModules;
1717

18-
var deepDiffer = require('deepDiffer');
18+
const deepDiffer = require('deepDiffer');
1919

20-
var TEST_PAYLOAD = {foo: 'bar'};
20+
const TEST_PAYLOAD = {foo: 'bar'};
2121

2222
type AppEvent = {data: Object, ts: number};
2323
type State = {
@@ -31,7 +31,7 @@ class AppEventsTest extends React.Component<{}, State> {
3131

3232
componentDidMount() {
3333
NativeAppEventEmitter.addListener('testEvent', this.receiveEvent);
34-
var event = {data: TEST_PAYLOAD, ts: Date.now()};
34+
const event = {data: TEST_PAYLOAD, ts: Date.now()};
3535
TestModule.sendAppEvent('testEvent', event);
3636
this.setState({sent: event});
3737
}
@@ -40,7 +40,7 @@ class AppEventsTest extends React.Component<{}, State> {
4040
if (deepDiffer(event.data, TEST_PAYLOAD)) {
4141
throw new Error('Received wrong event: ' + JSON.stringify(event));
4242
}
43-
var elapsed = Date.now() - event.ts + 'ms';
43+
const elapsed = Date.now() - event.ts + 'ms';
4444
this.setState({received: event, elapsed}, () => {
4545
TestModule.markTestCompleted();
4646
});
@@ -57,7 +57,7 @@ class AppEventsTest extends React.Component<{}, State> {
5757

5858
AppEventsTest.displayName = 'AppEventsTest';
5959

60-
var styles = StyleSheet.create({
60+
const styles = StyleSheet.create({
6161
container: {
6262
margin: 40,
6363
},

IntegrationTests/AsyncStorageTest.js

+16-16
Original file line numberDiff line numberDiff line change
@@ -10,27 +10,27 @@
1010

1111
'use strict';
1212

13-
var React = require('react');
14-
var ReactNative = require('react-native');
15-
var {AsyncStorage, Text, View} = ReactNative;
16-
var {TestModule} = ReactNative.NativeModules;
13+
const React = require('react');
14+
const ReactNative = require('react-native');
15+
const {AsyncStorage, Text, View} = ReactNative;
16+
const {TestModule} = ReactNative.NativeModules;
1717

18-
var deepDiffer = require('deepDiffer');
18+
const deepDiffer = require('deepDiffer');
1919

20-
var DEBUG = false;
20+
const DEBUG = false;
2121

22-
var KEY_1 = 'key_1';
23-
var VAL_1 = 'val_1';
24-
var KEY_2 = 'key_2';
25-
var VAL_2 = 'val_2';
26-
var KEY_MERGE = 'key_merge';
27-
var VAL_MERGE_1 = {foo: 1, bar: {hoo: 1, boo: 1}, moo: {a: 3}};
28-
var VAL_MERGE_2 = {bar: {hoo: 2}, baz: 2, moo: {a: 3}};
29-
var VAL_MERGE_EXPECT = {foo: 1, bar: {hoo: 2, boo: 1}, baz: 2, moo: {a: 3}};
22+
const KEY_1 = 'key_1';
23+
const VAL_1 = 'val_1';
24+
const KEY_2 = 'key_2';
25+
const VAL_2 = 'val_2';
26+
const KEY_MERGE = 'key_merge';
27+
const VAL_MERGE_1 = {foo: 1, bar: {hoo: 1, boo: 1}, moo: {a: 3}};
28+
const VAL_MERGE_2 = {bar: {hoo: 2}, baz: 2, moo: {a: 3}};
29+
const VAL_MERGE_EXPECT = {foo: 1, bar: {hoo: 2, boo: 1}, baz: 2, moo: {a: 3}};
3030

3131
// setup in componentDidMount
32-
var done = (result: ?boolean) => {};
33-
var updateMessage = (message: string) => {};
32+
let done = (result: ?boolean) => {};
33+
let updateMessage = (message: string) => {};
3434

3535
function runTestCase(description: string, fn) {
3636
updateMessage(description);

IntegrationTests/ImageCachePolicyTest.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010

1111
'use strict';
1212

13-
var React = require('react');
14-
var ReactNative = require('react-native');
15-
var {Image, View, Text, StyleSheet} = ReactNative;
16-
var {TestModule} = ReactNative.NativeModules;
13+
const React = require('react');
14+
const ReactNative = require('react-native');
15+
const {Image, View, Text, StyleSheet} = ReactNative;
16+
const {TestModule} = ReactNative.NativeModules;
1717

1818
/*
1919
* The reload and force-cache tests don't actually verify that the complete functionality.

IntegrationTests/ImageSnapshotTest.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010

1111
'use strict';
1212

13-
var React = require('react');
14-
var ReactNative = require('react-native');
15-
var {Image, View} = ReactNative;
16-
var {TestModule} = ReactNative.NativeModules;
13+
const React = require('react');
14+
const ReactNative = require('react-native');
15+
const {Image, View} = ReactNative;
16+
const {TestModule} = ReactNative.NativeModules;
1717

1818
class ImageSnapshotTest extends React.Component<{}> {
1919
componentDidMount() {

IntegrationTests/IntegrationTestHarnessTest.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@
1313
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
1414
* found when Flow v0.54 was deployed. To see the error delete this comment and
1515
* run Flow. */
16-
var requestAnimationFrame = require('fbjs/lib/requestAnimationFrame');
17-
var React = require('react');
18-
var PropTypes = require('prop-types');
19-
var ReactNative = require('react-native');
20-
var {Text, View} = ReactNative;
21-
var {TestModule} = ReactNative.NativeModules;
16+
const requestAnimationFrame = require('fbjs/lib/requestAnimationFrame');
17+
const React = require('react');
18+
const PropTypes = require('prop-types');
19+
const ReactNative = require('react-native');
20+
const {Text, View} = ReactNative;
21+
const {TestModule} = ReactNative.NativeModules;
2222

2323
class IntegrationTestHarnessTest extends React.Component<
2424
{

IntegrationTests/IntegrationTestsApp.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010

1111
'use strict';
1212

13-
var React = require('react');
14-
var ReactNative = require('react-native');
15-
var {
13+
const React = require('react');
14+
const ReactNative = require('react-native');
15+
const {
1616
AppRegistry,
1717
ScrollView,
1818
StyleSheet,
@@ -22,7 +22,7 @@ var {
2222
} = ReactNative;
2323

2424
// Keep this list in sync with RNTesterIntegrationTests.m
25-
var TESTS = [
25+
const TESTS = [
2626
require('./IntegrationTestHarnessTest'),
2727
require('./TimersTest'),
2828
require('./AsyncStorageTest'),
@@ -89,7 +89,7 @@ class IntegrationTestsApp extends React.Component<{}, $FlowFixMeState> {
8989
}
9090
}
9191

92-
var styles = StyleSheet.create({
92+
const styles = StyleSheet.create({
9393
container: {
9494
backgroundColor: 'white',
9595
marginTop: 40,

IntegrationTests/LayoutEventsTest.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@
1010

1111
'use strict';
1212

13-
var React = require('react');
14-
var createReactClass = require('create-react-class');
15-
var ReactNative = require('react-native');
16-
var {Image, LayoutAnimation, StyleSheet, Text, View} = ReactNative;
17-
var {TestModule} = ReactNative.NativeModules;
13+
const React = require('react');
14+
const createReactClass = require('create-react-class');
15+
const ReactNative = require('react-native');
16+
const {Image, LayoutAnimation, StyleSheet, Text, View} = ReactNative;
17+
const {TestModule} = ReactNative.NativeModules;
1818

19-
var deepDiffer = require('deepDiffer');
19+
const deepDiffer = require('deepDiffer');
2020

2121
function debug(...args) {
2222
// console.log.apply(null, arguments);
@@ -42,7 +42,7 @@ type State = {
4242
containerStyle?: Style,
4343
};
4444

45-
var LayoutEventsTest = createReactClass({
45+
const LayoutEventsTest = createReactClass({
4646
displayName: 'LayoutEventsTest',
4747
getInitialState(): State {
4848
return {
@@ -93,7 +93,7 @@ var LayoutEventsTest = createReactClass({
9393
},
9494
compare: function(node: string, measured: any, onLayout: any): void {
9595
if (deepDiffer(measured, onLayout)) {
96-
var data = {measured, onLayout};
96+
const data = {measured, onLayout};
9797
throw new Error(
9898
node +
9999
' onLayout mismatch with measure ' +
@@ -114,9 +114,9 @@ var LayoutEventsTest = createReactClass({
114114
this.setState({imageLayout: e.nativeEvent.layout}, this.checkLayout);
115115
},
116116
render: function() {
117-
var viewStyle = [styles.view, this.state.viewStyle];
118-
var textLayout = this.state.textLayout || {width: '?', height: '?'};
119-
var imageLayout = this.state.imageLayout || {x: '?', y: '?'};
117+
const viewStyle = [styles.view, this.state.viewStyle];
118+
const textLayout = this.state.textLayout || {width: '?', height: '?'};
119+
const imageLayout = this.state.imageLayout || {x: '?', y: '?'};
120120
debug('viewLayout', this.state.viewLayout);
121121
return (
122122
<View style={[styles.container, this.state.containerStyle]}>
@@ -141,7 +141,7 @@ var LayoutEventsTest = createReactClass({
141141
},
142142
});
143143

144-
var styles = StyleSheet.create({
144+
const styles = StyleSheet.create({
145145
container: {
146146
margin: 40,
147147
},

IntegrationTests/LoggingTestModule.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99

1010
'use strict';
1111

12-
var BatchedBridge = require('BatchedBridge');
12+
const BatchedBridge = require('BatchedBridge');
1313

14-
var warning = require('fbjs/lib/warning');
15-
var invariant = require('fbjs/lib/invariant');
14+
const warning = require('fbjs/lib/warning');
15+
const invariant = require('fbjs/lib/invariant');
1616

17-
var LoggingTestModule = {
17+
const LoggingTestModule = {
1818
logToConsole: function(str) {
1919
console.log(str);
2020
},

IntegrationTests/PromiseTest.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010

1111
'use strict';
1212

13-
var React = require('react');
14-
var ReactNative = require('react-native');
15-
var {View} = ReactNative;
16-
var {TestModule} = ReactNative.NativeModules;
13+
const React = require('react');
14+
const ReactNative = require('react-native');
15+
const {View} = ReactNative;
16+
const {TestModule} = ReactNative.NativeModules;
1717

1818
class PromiseTest extends React.Component<{}> {
1919
shouldResolve = false;

IntegrationTests/PropertiesUpdateTest.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@
99

1010
'use strict';
1111

12-
var React = require('react');
13-
var ReactNative = require('react-native');
14-
var {View} = ReactNative;
12+
const React = require('react');
13+
const ReactNative = require('react-native');
14+
const {View} = ReactNative;
1515

16-
var {TestModule} = ReactNative.NativeModules;
16+
const {TestModule} = ReactNative.NativeModules;
1717

1818
class PropertiesUpdateTest extends React.Component {
1919
render() {

IntegrationTests/RCTRootViewIntegrationTestApp.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111

1212
require('regenerator-runtime/runtime');
1313

14-
var React = require('react');
15-
var ReactNative = require('react-native');
14+
const React = require('react');
15+
const ReactNative = require('react-native');
1616

17-
var {
17+
const {
1818
AppRegistry,
1919
ScrollView,
2020
StyleSheet,
@@ -24,7 +24,7 @@ var {
2424
} = ReactNative;
2525

2626
/* Keep this list in sync with RCTRootViewIntegrationTests.m */
27-
var TESTS = [
27+
const TESTS = [
2828
require('./PropertiesUpdateTest'),
2929
require('./ReactContentSizeUpdateTest'),
3030
require('./SizeFlexibilityUpdateTest'),
@@ -70,7 +70,7 @@ class RCTRootViewIntegrationTestApp extends React.Component {
7070
}
7171
}
7272

73-
var styles = StyleSheet.create({
73+
const styles = StyleSheet.create({
7474
container: {
7575
backgroundColor: 'white',
7676
marginTop: 40,

IntegrationTests/ReactContentSizeUpdateTest.js

+13-13
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,23 @@
99

1010
'use strict';
1111

12-
var React = require('react');
13-
var createReactClass = require('create-react-class');
14-
var ReactNative = require('react-native');
15-
var RCTNativeAppEventEmitter = require('RCTNativeAppEventEmitter');
16-
var Subscribable = require('Subscribable');
17-
var TimerMixin = require('react-timer-mixin');
12+
const React = require('react');
13+
const createReactClass = require('create-react-class');
14+
const ReactNative = require('react-native');
15+
const RCTNativeAppEventEmitter = require('RCTNativeAppEventEmitter');
16+
const Subscribable = require('Subscribable');
17+
const TimerMixin = require('react-timer-mixin');
1818

19-
var {View} = ReactNative;
19+
const {View} = ReactNative;
2020

21-
var {TestModule} = ReactNative.NativeModules;
21+
const {TestModule} = ReactNative.NativeModules;
2222

23-
var reactViewWidth = 101;
24-
var reactViewHeight = 102;
25-
var newReactViewWidth = 201;
26-
var newReactViewHeight = 202;
23+
const reactViewWidth = 101;
24+
const reactViewHeight = 102;
25+
const newReactViewWidth = 201;
26+
const newReactViewHeight = 202;
2727

28-
var ReactContentSizeUpdateTest = createReactClass({
28+
const ReactContentSizeUpdateTest = createReactClass({
2929
displayName: 'ReactContentSizeUpdateTest',
3030
mixins: [Subscribable.Mixin, TimerMixin],
3131

IntegrationTests/SimpleSnapshotTest.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@
1010

1111
'use strict';
1212

13-
var React = require('react');
14-
var ReactNative = require('react-native');
13+
const React = require('react');
14+
const ReactNative = require('react-native');
1515
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
1616
* found when Flow v0.54 was deployed. To see the error delete this comment and
1717
* run Flow. */
18-
var requestAnimationFrame = require('fbjs/lib/requestAnimationFrame');
18+
const requestAnimationFrame = require('fbjs/lib/requestAnimationFrame');
1919

20-
var {StyleSheet, View} = ReactNative;
21-
var {TestModule} = ReactNative.NativeModules;
20+
const {StyleSheet, View} = ReactNative;
21+
const {TestModule} = ReactNative.NativeModules;
2222

2323
class SimpleSnapshotTest extends React.Component<{}> {
2424
componentDidMount() {
@@ -42,7 +42,7 @@ class SimpleSnapshotTest extends React.Component<{}> {
4242
}
4343
}
4444

45-
var styles = StyleSheet.create({
45+
const styles = StyleSheet.create({
4646
box1: {
4747
width: 80,
4848
height: 50,

0 commit comments

Comments
 (0)