Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable authentication #53

Open
davidcie opened this issue Mar 14, 2017 · 2 comments
Open

Disable authentication #53

davidcie opened this issue Mar 14, 2017 · 2 comments

Comments

@davidcie
Copy link

Had a look at both readme and code and it seems that, unless using a secret, both encryptionKey and signingKey are required and, essentially, both encryption and authentication are turned on by default.

In our case encryption is more than enough protection and we'd prefer to disable authentication for a small perf gain. Is this deliberate and the direction you want to take this plugin in or are you open to discussion on having auth optional?

@joegoldbeck
Copy link
Owner

@davidcie That's a good point! In general, I want to keep the number of code paths minimal, but this seems fairly reasonable. Feel free to submit a PR with a skipAuthentication option and associated tests/docs, and I'll make an effort to turn it around quickly. Seems like it shouldn't be too bad, let me know if you have any questions.

@davidcie
Copy link
Author

Thanks! Hope to find the time sometime later this week.

In our particular case we're trying to keep the size of each document down because the number of them is rather large. Hence every byte we can save per document translates to a couple thousand bytes not transferred over the wire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants