Non-Array Children Values Not Decryped After Save

[dereekb]

I ran into an issue where the children documents were not being recognized and decrypted properly. The children are not in an array, and just a single sub-document.

I'm using Typegoose and Mongoose:

"@typegoose/typegoose": "7.4.2",
"mongoose": "5.10.4",
"mongoose-encryption": "^2.0.3",

I made sure to add the encryptedChildren plugin, but noticed that both of the children documents were not being decrypted after saving. All other functions of the plugin are working great however, and the children are being decrypted properly when the models are loaded.

Digging into it, I noticed that the decryptEmbeddedDocs() function was only responding to nested documents if the value for that path was an array at time of decryption.

mongoose-encryption/lib/util/decryptEmbeddedDocs.js

Line 20 in 2b2fbe5

if (nestedDoc && nestedDoc[0] && isEmbeddedDocument(nestedDoc[0])) {

It looks like in your tests the children value is an array, and that's what is being tested against.

[joegoldbeck]

Ah, I wasn't aware of this use case of child documents! Probably makes sense to add support – happy to review any tested PRs.

https://stackoverflow.com/questions/23627976/mongoose-how-to-insert-a-single-subdocument-not-an-array/24724032