Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this work inside sheet()s? #2

Open
stammy opened this issue Jun 8, 2020 · 3 comments
Open

Does this work inside sheet()s? #2

stammy opened this issue Jun 8, 2020 · 3 comments

Comments

@stammy
Copy link

stammy commented Jun 8, 2020

If using NavigationView/Links inside sheet()s today it's not possible to bezel swipe back, would using this enable that?

@joehinkle11
Copy link
Owner

That would be a cool addition, but I don’t see why it would be needed since sheets are already dismissible with a downward swipe

@stammy
Copy link
Author

stammy commented Jul 5, 2020

This is for supporting the scenario where you want page nav inside the sheets, not just dismiss.

For example, imagine having a Settings view inside a sheet, with several of the options in that view requiring navigation links to push in for more options. I would not want to close the sheet, I would want the user to be able to easily bezel swipe back (easier than tapping the back arrow at the very top). If they dismissed the sheet that would mean the user would have to reopen the settings view when they just wanted to go back to the main settings view.

@joehinkle11
Copy link
Owner

I would imagine this would work already with the current implementation. If I get the chance, I'll try it. If it doesn't work, I'd imagine putting a VC view as the base view of the sheet would fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants