Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler integration with the Project Explorer (& Task Providers) #23

Closed
joelday opened this issue Mar 23, 2019 · 5 comments
Closed

Compiler integration with the Project Explorer (& Task Providers) #23

joelday opened this issue Mar 23, 2019 · 5 comments
Assignees

Comments

@joelday
Copy link
Owner

joelday commented Mar 23, 2019

  • Brings back @shad0wshayd3's hard work
  • Automatic task discovery/configuration based on found .ppj files
  • Tasks (contributed or configured) can be authored in tasks.json and resolved by the TaskProvider to configure execution.

Blocked by microsoft/vscode#33523

@joelday joelday added the enhancement New feature or request label Mar 23, 2019
@joelday
Copy link
Owner Author

joelday commented Mar 23, 2019

Can be done after microsoft/vscode#71027

@joelday
Copy link
Owner Author

joelday commented Mar 24, 2019

Repository owner deleted a comment from minkir014 May 30, 2019
@Scrivener07
Copy link
Collaborator

Scrivener07 commented Jun 23, 2019

If I recall correctly, you mentioned this will likely use the "Project Explorer" instead of the VS Code Task system. Ill tag this with the project explorer label so it shows up under that filter.

@Scrivener07 Scrivener07 changed the title Compiler integration with VSCode's Task system Compiler integration with the Project Explorer Jun 23, 2019
@Scrivener07
Copy link
Collaborator

Some context on where the tasks thing went.

Here's an example task provider: https://github.com/microsoft/vscode-extension-samples/blob/master/task-provider-sample/src/extension.ts

Problem is, if you add a custom task, like "type": "papyrus", you can't just add a bunch of custom configuration values to that. You must have a provider that provides specific tasks, and there has to be one that matches it.

https://github.com/microsoft/vscode-extension-samples/blob/master/task-provider-sample/src/extension.ts#L30
That never even gets called because it's not actually supported yet.

What we can do, though, is have a task schema that has an optional projectPath, where if it is missing, it just uses your CK .ini settings.
Then our provider would just search for all .ppj files. One benefit here would be, you could compile without even adding a tasks.json, you just pick it out of the command palette.

My thinking would be to just have the provider produce tasks for each combination of the (asm/debug/etc.) settings if you want to override.

@Scrivener07 Scrivener07 changed the title Compiler integration with the Project Explorer Compiler integration with the Project Explorer (& Task Providers) Jun 25, 2019
@rjstone
Copy link
Contributor

rjstone commented Nov 7, 2019

This is now done. We now autodiscover build tasks for .PPJ files (as soon as the PR I submitted with that fix gets merged, hint hint)

@rjstone rjstone closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants