Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnicodeDecodeError on german install #5

Open
shumpohl opened this issue Jun 13, 2022 · 1 comment
Open

UnicodeDecodeError on german install #5

shumpohl opened this issue Jun 13, 2022 · 1 comment

Comments

@shumpohl
Copy link

The return value of check_output in execute

subprocess.check_output(args).decode('utf-8')

contains

b'"description": "Leistungsstarke IDE, kostenlos f\x81r Studenten, Open-Source-Mitwirkende und Einzelpersonen"'

which looks like ü latin1 encoding to me and raises an UnicodeDecodeError on decoding. This seems to be a bug in vswhere itself but I am unsure if the -utf8 flag guarantees pure utf8 output.

python=3.8.13
pyvswhere=1.4.0
vswhere=3.0.1+e2e4e03c65
args=['C:\\Program Files (x86)\\Microsoft Visual Studio\\Installer\\vswhere.exe', '-utf8', '-latest', '-products', '*', '-requires', 'Microsoft.Component.MSBuild', '-format', 'json']
@Sil3ntStorm
Copy link

Seems like this might have been fixed upstream. Using a newer vswhere.exe should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants