-
Notifications
You must be signed in to change notification settings - Fork 10
g:minisnip_finalstartdelim conflicts with Go templates #45
Comments
I would not be in favor of this change. The variable can be changed if you don't like it and a "better default" is highly subjective. |
It's not about "liking", it's about conflicting with a reasonably common language. That's not a "highly subjective" matter, and I would argue that anything that doesn't conflict with anything common is objectively better as a simple pragmatical matter. |
You can change them to not conflict so no change to minisnip is needed. It is about liking. |
Yes, I am aware. But then everyone writing Go templates will run in to this problem (which is rather confusing) and then have to change it. A default that no one has to change is better. The biggest issue is one of backwards compatibility, and whether it's worth the change. |
And when another language comes out with a template that uses whatever minisnip changes its default to then the discussion happens all over again. If I could vote, it would be no. It works for everyone now and allows the default to change when it needs to do so. |
Just as a note, not sure Joe is updating minisnip these days but I could be wrong. |
There are choices that are much less likely to conflict with anything.
Yeah, I don't know either. I wanted to document the issue in either case, even if no action is taken. |
Not recently, I'm busy with other projects at the moment and it conflicted in some ways with coc.nvim so I stopped using it. I'm not sure if that's still the case though. I do intend to get back on it one day, but I have other things going on at the moment, I appreciate the enthusiasm though! :D |
The syntax for Go templates is:
You can control leading and trailing whitespace by adding
-
:That last variant conflicts with minisnip's
g:minisnip_finalstartdelim
, which is rather annoying.I know this variable can be changed, but it seems to me that using a better default would be, well, better. Something like
{{|-
should be much more unique.On the other hand, changing this would break compatibility for people with existing templates :-/
Not sure what the best course of action it. Either way, I thought I'd report it here.
The text was updated successfully, but these errors were encountered: