Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about deprecated set-output command #9

Closed
alexciesielski opened this issue Nov 30, 2022 · 5 comments · Fixed by #10
Closed

Warning about deprecated set-output command #9

alexciesielski opened this issue Nov 30, 2022 · 5 comments · Fixed by #10

Comments

@alexciesielski
Copy link
Contributor

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@joerick
Copy link
Owner

joerick commented Nov 30, 2022

prs welcome!

@alexciesielski
Copy link
Contributor Author

Happy to hear, was worried that the repo has become inactive :)
I took a look at the git client and it seems that they have deprecated the command without giving an alternative lol:

actions/toolkit#1218

I'm subscribed to this - once they push an update to the client I'll open a PR here.

Cheers

@educorzo
Copy link

Hi @joerick,
Any plan for merging this PR and close this issue?

@kimlep01
Copy link

Hi, I updated my workflow to use v1.0.8 and I'm still seeing the same warnings

My repo:

Run joerick/pr-labels-action@v1.0.8

Found label  do-not-merge 
  Setting env var for remaining steps: GITHUB_PR_LABEL_DO_NOT_MERGE=1

Action output:
labels: " do-not-merge "
labels-object: {"do-not-merge":true}
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Latest PR check in this repo https://github.com/joerick/pr-labels-action/actions/runs/4469843040/jobs/7852529676:

Run ./
Not a pull request
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/[2](https://github.com/joerick/pr-labels-action/actions/runs/4469843040/jobs/7852529676#step:3:3)022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Could you verify and reopen this ticket? This will start failing on June 1st.

@alexciesielski
Copy link
Contributor Author

Looks like the dist folder has not been updated? I still see the set-output command here: https://github.com/joerick/pr-labels-action/blob/main/dist/index.js#L333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants