Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recenter dock items when dock width is set to a fixed value #610

Closed
purpasmart96 opened this issue Jun 24, 2024 · 2 comments · Fixed by #611
Closed

Recenter dock items when dock width is set to a fixed value #610

purpasmart96 opened this issue Jun 24, 2024 · 2 comments · Fixed by #611

Comments

@purpasmart96
Copy link
Contributor

When you use the width attribute for the Dock/systray like this

<Dock width=24/>

You do indeed get the proper size for the dock items. However, now they are no longer properly aligned to the middle of the tray and are instead being pushed to the top

dock_width_24

My attempt to resolve this issue is by adding an x or y offset to the dock window when it gets resized.

dock_width_24_icons_centered

Here is the fix: purpasmart96@c2f301e

My fix seems to work, but I would like to hear some feedback before submitting a PR, as per your guidelines.

@joewing
Copy link
Owner

joewing commented Jun 24, 2024

Thanks for fixing this! That fix looks good to me. Please feel free to open a PR and I'll merge it in.

@purpasmart96
Copy link
Contributor Author

Great! I will go ahead and do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants