Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background colours broken #640

Closed
bkauler opened this issue Oct 21, 2024 · 8 comments
Closed

Background colours broken #640

bkauler opened this issue Oct 21, 2024 · 8 comments

Comments

@bkauler
Copy link

bkauler commented Oct 21, 2024

EasyOS is currently using jwm 2.4.2
I thought should update, did so, but found background colours are wrong. It seems this is due to a syntax change.
So, have stayed with 2.4.2.

We have been through this before. EasyOS, Puppy Linux and derivatives have lots of jwm theme PET packages, and the last major syntax change we had to update many of them. Don't want to do it again.

@joewing
Copy link
Owner

joewing commented Nov 2, 2024

There shouldn't be a syntax change between 2.4.2 and 2.4.5. This is for desktop backgrounds? Is there a small config snippet to demonstrate the problem?

@bkauler
Copy link
Author

bkauler commented Nov 4, 2024

Sorry, I made a mistake, seems I was accidentally using an older jwm theme PET package.
Sorry for wasting your time, closing this issue.

@bkauler bkauler closed this as completed Nov 4, 2024
@bkauler
Copy link
Author

bkauler commented Nov 5, 2024

No, I am correct, found the wrong colour...

@bkauler bkauler reopened this Nov 5, 2024
@bkauler
Copy link
Author

bkauler commented Nov 5, 2024

When an app is minimized, its background colour is wrong. This is jwm 2.4.4 and the two minimized in the tray have a dark-brown background:
jwm-2 4 4-wrong-bg

@bkauler
Copy link
Author

bkauler commented Nov 5, 2024

I restarted X with jwm 2.4.2, now minimized apps are the correct colour. In this snapshot, Chromium is minimized and it is the expected light blue background:
jwm-2 4 2-ok-bg

@bkauler
Copy link
Author

bkauler commented Nov 5, 2024

Here is the fragment:

	<TaskListStyle>
		<Font>Open Sans-12</Font>
		<Active>
			<Foreground>#edf9ff</Foreground>
			<Background>#3761b6</Background>
		</Active>
		<Background>#72c8eb</Background>
		<Foreground>#304a9f</Foreground>
	</TaskListStyle>

Also the text foreground colour of the minimized app is wrong.

@joewing
Copy link
Owner

joewing commented Nov 5, 2024

Thanks! I see the problem. A new feature inadvertently broke this (minimized window styles). It's an easy fix though.

@joewing
Copy link
Owner

joewing commented Nov 5, 2024

The fix is merged. I'll try to get a release out within a week or so.

@joewing joewing closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants