Skip to content

Commit dadc516

Browse files
author
Max Heiber
committed
simplify and fixes for private methods emit
Signed-off-by: Max Heiber <mheiber@bloomberg.net>
1 parent ab3a3b1 commit dadc516

14 files changed

+172
-111
lines changed

‎src/compiler/transformers/esnext.ts‎

Lines changed: 30 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -414,17 +414,8 @@ namespace ts {
414414
const containsPropertyInitializer = forEach(node.members, isInitializedProperty);
415415
let body = constructor ? constructor.body : undefined;
416416
let parameters = constructor ? constructor.parameters : undefined;
417-
const shouldTransformConstructorBody = containsPropertyInitializer || declaresPrivateNames;
418-
if (shouldTransformConstructorBody) {
419-
if (containsPropertyInitializer) {
420-
parameters = visitParameterList(constructor ? constructor.parameters : undefined, visitor, context);
421-
}
422-
else {
423-
// provide a scope for hoisted declarations for WeakSet or WeakMap for private name brand checks
424-
// not needed if `visitParameterList` was called, because that starts/suspends the lexical environment
425-
context.startLexicalEnvironment();
426-
context.suspendLexicalEnvironment();
427-
}
417+
if (containsPropertyInitializer || declaresPrivateNames) {
418+
parameters = visitParameterList(constructor ? constructor.parameters : undefined, visitor, context);
428419
body = transformConstructorBody(node, constructor, isDerivedClass, declaresPrivateNames);
429420
}
430421
if (!body) {
@@ -486,22 +477,11 @@ namespace ts {
486477
indexOfFirstStatement = addPrologueDirectivesAndInitialSuperCall(constructor, statements, visitor);
487478
}
488479

489-
// Add the property initializers. Transforms this:
490-
//
491-
// public x = 1;
492-
//
493-
// Into this:
494-
//
495-
// constructor() {
496-
// this.x = 1;
497-
// }
498-
//
499-
addInitializedPropertyStatements(statements, properties, createThis());
500480
if (classDeclaresPrivateNames) {
501481
last(privateNameEnvironmentStack).forEach(({ placement, accumulator }) => {
502482
switch (placement) {
503483
case PrivateNamePlacement.InstanceField:
504-
// TODO: instance field add accumulator
484+
// handled in addInitializedPropertyStatements
505485
break;
506486
case PrivateNamePlacement.InstanceMethod:
507487
statements.push(
@@ -517,6 +497,17 @@ namespace ts {
517497
}
518498
});
519499
}
500+
// Add the property initializers. Transforms this:
501+
//
502+
// public x = 1;
503+
//
504+
// Into this:
505+
//
506+
// constructor() {
507+
// this.x = 1;
508+
// }
509+
//
510+
addInitializedPropertyStatements(statements, properties, createThis());
520511

521512
// Add existing statements, skipping the initial super call.
522513
if (constructor) {
@@ -656,7 +647,7 @@ namespace ts {
656647
function addPrivateName(element: ClassElement & { name: PrivateName }) {
657648
const env = last(privateNameEnvironmentStack);
658649
const text = getTextOfPropertyName(element.name) as string;
659-
const accumulator = createFileLevelUniqueName(`_${text.substring(1)}Private`);
650+
const accumulator = createFileLevelUniqueName(`_${text.substring(1)}`);
660651
const { escapedText } = element.name;
661652
hoistVariableDeclaration(accumulator);
662653

@@ -705,21 +696,18 @@ namespace ts {
705696
function visitPropertyAccessExpression(node: PropertyAccessExpression) {
706697
if (isPrivateName(node.name)) {
707698
const privateNameInfo = accessPrivateName(node.name);
708-
if (privateNameInfo) {
709-
switch (privateNameInfo.placement) {
710-
case PrivateNamePlacement.InstanceField:
711-
return setOriginalNode(
712-
setTextRange(
713-
createClassPrivateFieldGetHelper(
714-
context,
715-
visitNode(node.expression, visitor, isExpression),
716-
privateNameInfo.accumulator
717-
),
718-
node
719-
),
720-
node
721-
);
722-
}
699+
if (privateNameInfo && privateNameInfo.placement === PrivateNamePlacement.InstanceField) {
700+
return setOriginalNode(
701+
setTextRange(
702+
createClassPrivateFieldGetHelper(
703+
context,
704+
visitNode(node.expression, visitor, isExpression),
705+
privateNameInfo.accumulator
706+
),
707+
node
708+
),
709+
node
710+
);
723711
}
724712
}
725713
return visitEachChild(node, visitor, context);
@@ -808,7 +796,9 @@ namespace ts {
808796
);
809797
receiver = generatedName;
810798
}
811-
const privateNameEntry = last(privateNameEnvironmentStack).get(node.expression.name.escapedText);
799+
const privateNameEntry = privateNameEnvironmentStack.length
800+
? last(privateNameEnvironmentStack).get(node.expression.name.escapedText)
801+
: undefined;
812802
if (privateNameEntry && privateNameEntry.placement === PrivateNamePlacement.InstanceMethod) {
813803
return setOriginalNode(
814804
setTextRange(

‎tests/baselines/reference/privateNameField.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ class A {
88

99
//// [privateNameField.js]
1010
var _classPrivateFieldSet = function (receiver, privateMap, value) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to set private field on non-instance"); } privateMap.set(receiver, value); return value; };
11-
var _namePrivate;
11+
var _name;
1212
var A = /** @class */ (function () {
1313
function A(name) {
14-
_namePrivate.set(this, void 0);
15-
_classPrivateFieldSet(this, _namePrivate, name);
14+
_name.set(this, void 0);
15+
_classPrivateFieldSet(this, _name, name);
1616
}
1717
return A;
1818
}());
19-
_namePrivate = new WeakMap();
19+
_name = new WeakMap();

‎tests/baselines/reference/privateNameFieldAccess.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ class A {
99

1010
//// [privateNameFieldAccess.js]
1111
var _classPrivateFieldGet = function (receiver, privateMap) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to get private field on non-instance"); } return privateMap.get(receiver); };
12-
var _myFieldPrivate;
12+
var _myField;
1313
var A = /** @class */ (function () {
1414
function A() {
15-
_myFieldPrivate.set(this, "hello world");
16-
console.log(_classPrivateFieldGet(this, _myFieldPrivate));
15+
_myField.set(this, "hello world");
16+
console.log(_classPrivateFieldGet(this, _myField));
1717
}
1818
return A;
1919
}());
20-
_myFieldPrivate = new WeakMap();
20+
_myField = new WeakMap();

‎tests/baselines/reference/privateNameFieldAssignment.js‎

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -38,41 +38,41 @@ class A {
3838
//// [privateNameFieldAssignment.js]
3939
var _classPrivateFieldSet = function (receiver, privateMap, value) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to set private field on non-instance"); } privateMap.set(receiver, value); return value; };
4040
var _classPrivateFieldGet = function (receiver, privateMap) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to get private field on non-instance"); } return privateMap.get(receiver); };
41-
var _fieldPrivate;
41+
var _field;
4242
var A = /** @class */ (function () {
4343
function A() {
44-
_fieldPrivate.set(this, 0);
44+
_field.set(this, 0);
4545
var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m;
46-
_classPrivateFieldSet(this, _fieldPrivate, 1);
47-
_classPrivateFieldSet(this, _fieldPrivate, _classPrivateFieldGet(this, _fieldPrivate) + 2);
48-
_classPrivateFieldSet(this, _fieldPrivate, _classPrivateFieldGet(this, _fieldPrivate) - 3);
49-
_classPrivateFieldSet(this, _fieldPrivate, _classPrivateFieldGet(this, _fieldPrivate) / 4);
50-
_classPrivateFieldSet(this, _fieldPrivate, _classPrivateFieldGet(this, _fieldPrivate) * 5);
51-
_classPrivateFieldSet(this, _fieldPrivate, Math.pow(_classPrivateFieldGet(this, _fieldPrivate), 6));
52-
_classPrivateFieldSet(this, _fieldPrivate, _classPrivateFieldGet(this, _fieldPrivate) % 7);
53-
_classPrivateFieldSet(this, _fieldPrivate, _classPrivateFieldGet(this, _fieldPrivate) << 8);
54-
_classPrivateFieldSet(this, _fieldPrivate, _classPrivateFieldGet(this, _fieldPrivate) >> 9);
55-
_classPrivateFieldSet(this, _fieldPrivate, _classPrivateFieldGet(this, _fieldPrivate) >>> 10);
56-
_classPrivateFieldSet(this, _fieldPrivate, _classPrivateFieldGet(this, _fieldPrivate) & 11);
57-
_classPrivateFieldSet(this, _fieldPrivate, _classPrivateFieldGet(this, _fieldPrivate) | 12);
58-
_classPrivateFieldSet(this, _fieldPrivate, _classPrivateFieldGet(this, _fieldPrivate) ^ 13);
59-
_classPrivateFieldSet(A.getInstance(), _fieldPrivate, 1);
60-
_classPrivateFieldSet(_a = A.getInstance(), _fieldPrivate, _classPrivateFieldGet(_a, _fieldPrivate) + 2);
61-
_classPrivateFieldSet(_b = A.getInstance(), _fieldPrivate, _classPrivateFieldGet(_b, _fieldPrivate) - 3);
62-
_classPrivateFieldSet(_c = A.getInstance(), _fieldPrivate, _classPrivateFieldGet(_c, _fieldPrivate) / 4);
63-
_classPrivateFieldSet(_d = A.getInstance(), _fieldPrivate, _classPrivateFieldGet(_d, _fieldPrivate) * 5);
64-
_classPrivateFieldSet(_e = A.getInstance(), _fieldPrivate, Math.pow(_classPrivateFieldGet(_e, _fieldPrivate), 6));
65-
_classPrivateFieldSet(_f = A.getInstance(), _fieldPrivate, _classPrivateFieldGet(_f, _fieldPrivate) % 7);
66-
_classPrivateFieldSet(_g = A.getInstance(), _fieldPrivate, _classPrivateFieldGet(_g, _fieldPrivate) << 8);
67-
_classPrivateFieldSet(_h = A.getInstance(), _fieldPrivate, _classPrivateFieldGet(_h, _fieldPrivate) >> 9);
68-
_classPrivateFieldSet(_j = A.getInstance(), _fieldPrivate, _classPrivateFieldGet(_j, _fieldPrivate) >>> 10);
69-
_classPrivateFieldSet(_k = A.getInstance(), _fieldPrivate, _classPrivateFieldGet(_k, _fieldPrivate) & 11);
70-
_classPrivateFieldSet(_l = A.getInstance(), _fieldPrivate, _classPrivateFieldGet(_l, _fieldPrivate) | 12);
71-
_classPrivateFieldSet(_m = A.getInstance(), _fieldPrivate, _classPrivateFieldGet(_m, _fieldPrivate) ^ 13);
46+
_classPrivateFieldSet(this, _field, 1);
47+
_classPrivateFieldSet(this, _field, _classPrivateFieldGet(this, _field) + 2);
48+
_classPrivateFieldSet(this, _field, _classPrivateFieldGet(this, _field) - 3);
49+
_classPrivateFieldSet(this, _field, _classPrivateFieldGet(this, _field) / 4);
50+
_classPrivateFieldSet(this, _field, _classPrivateFieldGet(this, _field) * 5);
51+
_classPrivateFieldSet(this, _field, Math.pow(_classPrivateFieldGet(this, _field), 6));
52+
_classPrivateFieldSet(this, _field, _classPrivateFieldGet(this, _field) % 7);
53+
_classPrivateFieldSet(this, _field, _classPrivateFieldGet(this, _field) << 8);
54+
_classPrivateFieldSet(this, _field, _classPrivateFieldGet(this, _field) >> 9);
55+
_classPrivateFieldSet(this, _field, _classPrivateFieldGet(this, _field) >>> 10);
56+
_classPrivateFieldSet(this, _field, _classPrivateFieldGet(this, _field) & 11);
57+
_classPrivateFieldSet(this, _field, _classPrivateFieldGet(this, _field) | 12);
58+
_classPrivateFieldSet(this, _field, _classPrivateFieldGet(this, _field) ^ 13);
59+
_classPrivateFieldSet(A.getInstance(), _field, 1);
60+
_classPrivateFieldSet(_a = A.getInstance(), _field, _classPrivateFieldGet(_a, _field) + 2);
61+
_classPrivateFieldSet(_b = A.getInstance(), _field, _classPrivateFieldGet(_b, _field) - 3);
62+
_classPrivateFieldSet(_c = A.getInstance(), _field, _classPrivateFieldGet(_c, _field) / 4);
63+
_classPrivateFieldSet(_d = A.getInstance(), _field, _classPrivateFieldGet(_d, _field) * 5);
64+
_classPrivateFieldSet(_e = A.getInstance(), _field, Math.pow(_classPrivateFieldGet(_e, _field), 6));
65+
_classPrivateFieldSet(_f = A.getInstance(), _field, _classPrivateFieldGet(_f, _field) % 7);
66+
_classPrivateFieldSet(_g = A.getInstance(), _field, _classPrivateFieldGet(_g, _field) << 8);
67+
_classPrivateFieldSet(_h = A.getInstance(), _field, _classPrivateFieldGet(_h, _field) >> 9);
68+
_classPrivateFieldSet(_j = A.getInstance(), _field, _classPrivateFieldGet(_j, _field) >>> 10);
69+
_classPrivateFieldSet(_k = A.getInstance(), _field, _classPrivateFieldGet(_k, _field) & 11);
70+
_classPrivateFieldSet(_l = A.getInstance(), _field, _classPrivateFieldGet(_l, _field) | 12);
71+
_classPrivateFieldSet(_m = A.getInstance(), _field, _classPrivateFieldGet(_m, _field) ^ 13);
7272
}
7373
A.getInstance = function () {
7474
return new A();
7575
};
7676
return A;
7777
}());
78-
_fieldPrivate = new WeakMap();
78+
_field = new WeakMap();

‎tests/baselines/reference/privateNameFieldCallExpression.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@ class A {
1212

1313
//// [privateNameFieldCallExpression.js]
1414
var _classPrivateFieldGet = function (receiver, privateMap) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to get private field on non-instance"); } return privateMap.get(receiver); };
15-
var _fieldFuncPrivate;
15+
var _fieldFunc;
1616
var A = /** @class */ (function () {
1717
function A() {
1818
var _this = this;
19-
_fieldFuncPrivate.set(this, function () { return _this.x = 10; });
19+
_fieldFunc.set(this, function () { return _this.x = 10; });
2020
this.x = 1;
2121
}
2222
A.prototype.test = function () {
23-
_classPrivateFieldGet(this, _fieldFuncPrivate).call(this);
24-
var func = _classPrivateFieldGet(this, _fieldFuncPrivate);
23+
_classPrivateFieldGet(this, _fieldFunc).call(this);
24+
var func = _classPrivateFieldGet(this, _fieldFunc);
2525
func();
2626
};
2727
return A;
2828
}());
29-
_fieldFuncPrivate = new WeakMap();
29+
_fieldFunc = new WeakMap();

‎tests/baselines/reference/privateNameFieldDeclaration.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ class A {
55

66

77
//// [privateNameFieldDeclaration.js]
8-
var _namePrivate;
8+
var _name;
99
var A = /** @class */ (function () {
1010
function A() {
11-
_namePrivate.set(this, void 0);
11+
_name.set(this, void 0);
1212
}
1313
return A;
1414
}());
15-
_namePrivate = new WeakMap();
15+
_name = new WeakMap();

‎tests/baselines/reference/privateNameFieldDestructuredBinding.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ class A {
1717

1818
//// [privateNameFieldDestructuredBinding.js]
1919
var _classPrivateFieldGet = function (receiver, privateMap) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to get private field on non-instance"); } return privateMap.get(receiver); };
20-
var _fieldPrivate;
20+
var _field;
2121
var A = /** @class */ (function () {
2222
function A() {
23-
_fieldPrivate.set(this, 1);
23+
_field.set(this, 1);
2424
var _a, _b;
2525
var y;
26-
(_a = this.testObject(), { set value(x) { _classPrivateFieldGet(this, _fieldPrivate) = x; } }.value = _a.x, y = _a.y);
27-
(_b = this.testArray(), { set value(x) { _classPrivateFieldGet(this, _fieldPrivate) = x; } }.value = _b[0], y = _b[1]);
26+
(_a = this.testObject(), { set value(x) { _classPrivateFieldGet(this, _field) = x; } }.value = _a.x, y = _a.y);
27+
(_b = this.testArray(), { set value(x) { _classPrivateFieldGet(this, _field) = x; } }.value = _b[0], y = _b[1]);
2828
}
2929
A.prototype.testObject = function () {
3030
return { x: 10, y: 6 };
@@ -34,4 +34,4 @@ var A = /** @class */ (function () {
3434
};
3535
return A;
3636
}());
37-
_fieldPrivate = new WeakMap();
37+
_field = new WeakMap();

‎tests/baselines/reference/privateNameFieldInitializer.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ class A {
66

77

88
//// [privateNameFieldInitializer.js]
9-
var _fieldPrivate, _uninitializedPrivate;
9+
var _field, _uninitialized;
1010
var A = /** @class */ (function () {
1111
function A() {
12-
_fieldPrivate.set(this, 10);
13-
_uninitializedPrivate.set(this, void 0);
12+
_field.set(this, 10);
13+
_uninitialized.set(this, void 0);
1414
}
1515
return A;
1616
}());
17-
_fieldPrivate = new WeakMap(), _uninitializedPrivate = new WeakMap();
17+
_field = new WeakMap(), _uninitialized = new WeakMap();

‎tests/baselines/reference/privateNameFieldUnaryMutation.js‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,24 +20,24 @@ class C {
2020
//// [privateNameFieldUnaryMutation.js]
2121
var _classPrivateFieldGet = function (receiver, privateMap) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to get private field on non-instance"); } return privateMap.get(receiver); };
2222
var _classPrivateFieldSet = function (receiver, privateMap, value) { if (!privateMap.has(receiver)) { throw new TypeError("attempted to set private field on non-instance"); } privateMap.set(receiver, value); return value; };
23-
var _testPrivate;
23+
var _test;
2424
var C = /** @class */ (function () {
2525
function C() {
26-
_testPrivate.set(this, 24);
26+
_test.set(this, 24);
2727
var _a, _b;
28-
_a = _classPrivateFieldGet(this, _testPrivate), _classPrivateFieldSet(this, _testPrivate, _a + 1), _a;
29-
_b = _classPrivateFieldGet(this, _testPrivate), _classPrivateFieldSet(this, _testPrivate, _b - 1), _b;
30-
_classPrivateFieldSet(this, _testPrivate, _classPrivateFieldGet(this, _testPrivate) + 1);
31-
_classPrivateFieldSet(this, _testPrivate, _classPrivateFieldGet(this, _testPrivate) - 1);
28+
_a = _classPrivateFieldGet(this, _test), _classPrivateFieldSet(this, _test, _a + 1), _a;
29+
_b = _classPrivateFieldGet(this, _test), _classPrivateFieldSet(this, _test, _b - 1), _b;
30+
_classPrivateFieldSet(this, _test, _classPrivateFieldGet(this, _test) + 1);
31+
_classPrivateFieldSet(this, _test, _classPrivateFieldGet(this, _test) - 1);
3232
}
3333
C.prototype.test = function () {
3434
var _a, _b, _c, _d, _e, _f;
35-
_a = this.getInstance(), _b = _classPrivateFieldGet(_a, _testPrivate), _classPrivateFieldSet(_a, _testPrivate, _b + 1), _b;
36-
_c = this.getInstance(), _d = _classPrivateFieldGet(_c, _testPrivate), _classPrivateFieldSet(_c, _testPrivate, _d - 1), _d;
37-
_classPrivateFieldSet(_e = this.getInstance(), _testPrivate, _classPrivateFieldGet(_e, _testPrivate) + 1);
38-
_classPrivateFieldSet(_f = this.getInstance(), _testPrivate, _classPrivateFieldGet(_f, _testPrivate) - 1);
35+
_a = this.getInstance(), _b = _classPrivateFieldGet(_a, _test), _classPrivateFieldSet(_a, _test, _b + 1), _b;
36+
_c = this.getInstance(), _d = _classPrivateFieldGet(_c, _test), _classPrivateFieldSet(_c, _test, _d - 1), _d;
37+
_classPrivateFieldSet(_e = this.getInstance(), _test, _classPrivateFieldGet(_e, _test) + 1);
38+
_classPrivateFieldSet(_f = this.getInstance(), _test, _classPrivateFieldGet(_f, _test) - 1);
3939
};
4040
C.prototype.getInstance = function () { return new C(); };
4141
return C;
4242
}());
43-
_testPrivate = new WeakMap();
43+
_test = new WeakMap();

‎tests/baselines/reference/privateNameNestedClassNameConflict.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,19 @@ class A {
99
}
1010

1111
//// [privateNameNestedClassNameConflict.js]
12-
var _fooPrivate;
12+
var _foo;
1313
var A = /** @class */ (function () {
1414
function A() {
15-
_fooPrivate.set(this, void 0);
16-
var _fooPrivate;
15+
_foo.set(this, void 0);
16+
var _foo;
1717
var A = /** @class */ (function () {
1818
function A() {
19-
_fooPrivate.set(this, void 0);
19+
_foo.set(this, void 0);
2020
}
2121
return A;
2222
}());
23-
_fooPrivate = new WeakMap();
23+
_foo = new WeakMap();
2424
}
2525
return A;
2626
}());
27-
_fooPrivate = new WeakMap();
27+
_foo = new WeakMap();

0 commit comments

Comments
 (0)