Add cloudflare origin issuer #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent us from requesting the CA cert on every issue request.
golangcibot
reviewed
Jul 17, 2019
| }), | ||
| } | ||
|
|
||
| caCert, caKey, err := certs.GenerateCertAndKey() |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
| }), | ||
| } | ||
|
|
||
| caCert, caKey, err := certs.GenerateCertAndKey() |
There was a problem hiding this comment.
ineffectual assignment to err (from ineffassign)
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
- Coverage 67.67% 65.55% -2.13%
==========================================
Files 9 11 +2
Lines 461 511 +50
==========================================
+ Hits 312 335 +23
- Misses 98 120 +22
- Partials 51 56 +5
Continue to review full report at Codecov.
|
|
Need to add CF Origin to sidecar as well before we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
Still WIP until I can successfully test this against the API.