Prefer id over name consul check filename #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgwizard This would be a breaking change for anyone upgrading the version of the Consul cookbook they're using. We need to have a migration step here that checks if the name identified file is present while the id one is not and deletes the name identified one. |
|
@reset yes this is unnecessarily a breaking change. I'll add that step, to remove the |
That also have an id and that now will be registered with id in the path. Also add specs for this and for other check_def logic.
|
@reset @johnbellone what do you think? |
|
@tgwizard looks good to me, thank you for following up with a migration! |
reset
added a commit
that referenced
this pull request
Dec 16, 2014
Prefer id over name consul check filename
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99. I chose to do it with a fallback, the same was as for service definitions, as id isn't required, and name is used as id in consul if id isn't specified.