use configfile instead of hardcoding values into init file #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged #11 please rebase this. |
|
rebased. |
|
I really hate JSON configuration files. I would much rather prefer if we were able to use a template for this kind of stuff. |
johnbellone
pushed a commit
that referenced
this pull request
Jun 6, 2014
use configfile instead of hardcoding values into init file
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of a config json in the config dir.
It is rebased to your current master, so it still uses the artificial console_ui path for the web ui, and would need further adjustment should you decide to merge #11.
Just tell me to rebase and I'll happily do so.