Add HWRPs for installing and managing consul. #126

johnbellone · 2015-02-08T21:09:00Z

I am channeling @someara and @reset here.

After taking a look at the new httpd library cookbook as well
as the Mysql library cookbook I think this is an excellent example
of using HWRP for defining the building blocks of a quality cookbook.

coveralls · 2015-02-08T21:14:45Z

Coverage decreased (-2.86%) to 97.14% when pulling 41eee88 on develop into 57b4105 on master.

reset · 2015-02-08T21:39:09Z

@johnbellone excellent work man! I really like having the ability to swap service providers for the service resource. That'll let people implement and test whatever service startup tool they use (runit, systemd, etc). Comment here again when it's finished and I'll take another look ;)

libraries/provider_consul_client_source.rb

+  action :create do
+    include_recipe 'golang::default'
+
+    directory File.join(node['go']['gopath'], 'src/github.com/hashicorp') do


someara · 2015-02-08T21:47:38Z

This is great. I'm so happy to see people copying this pattern.

+100.

On Sun, Feb 8, 2015 at 4:39 PM, Jamie Winsor notifications@github.com
wrote:

@johnbellone https://github.com/johnbellone excellent work man! I
really like having the ability to swap service providers for the service
resource. That'll let people implement and test whatever service startup
tool they use (runit, systemd, etc). Comment here again when it's finished
and I'll take another look ;)

—
Reply to this email directly or view it on GitHub
#126 (comment)
.

coveralls · 2015-02-08T21:50:43Z

Coverage decreased (-2.86%) to 97.14% when pulling ad41f68 on develop into 57b4105 on master.

coveralls · 2015-02-09T01:18:26Z

Coverage decreased (-2.86%) to 97.14% when pulling 14c3bc7 on develop into 57b4105 on master.

coveralls · 2015-02-10T03:06:57Z

Coverage decreased (-2.86%) to 97.14% when pulling 31ed5ac on develop into 57b4105 on master.

coveralls · 2015-02-10T03:11:35Z

Coverage decreased (-2.86%) to 97.14% when pulling 31ed5ac on develop into 57b4105 on master.

coveralls · 2015-02-13T04:02:57Z

Coverage decreased (-2.86%) to 97.14% when pulling d8ba236 on develop into 57b4105 on master.

coveralls · 2015-02-14T02:00:43Z

Coverage decreased (-2.86%) to 97.14% when pulling 6387c6d on develop into 57b4105 on master.

coveralls · 2015-02-14T02:04:46Z

Coverage decreased (-2.86%) to 97.14% when pulling 6387c6d on develop into 57b4105 on master.

coveralls · 2015-02-14T02:05:44Z

Coverage decreased (-2.86%) to 97.14% when pulling 6387c6d on develop into 57b4105 on master.

coveralls · 2015-02-14T02:12:34Z

Coverage decreased (-2.86%) to 97.14% when pulling 11adc9c on develop into 57b4105 on master.

coveralls · 2015-02-24T11:49:59Z

Coverage remained the same at 100.0% when pulling 5b8b84c on develop into 57b4105 on master.

fujin · 2015-03-09T20:53:05Z

hey there, tried to give this a test, but getting:

* consul_client[/opt/consul/0.4.1] action create (up to date)


           ================================================================================
           Error executing action `create` on resource 'consul_config[/etc/consul.d/default.json]'
           ================================================================================

           NoMethodError
           -------------
           undefined method `parsed_run_user' for Chef::Resource::Directory

           Cookbook Trace:
           ---------------
           /tmp/kitchen/cache/cookbooks/consul/libraries/provider_consul_config.rb:20:in `block (2 levels) in <class:ConsulConfig>'
           /tmp/kitchen/cache/cookbooks/consul/libraries/provider_consul_config.rb:19:in `block in <class:ConsulConfig>'

           Resource Declaration:
           ---------------------
           # In /tmp/kitchen/cache/cookbooks/consul/recipes/default.rb

            18: config = consul_config File.join(node['consul']['config_dir'], 'default.json') do
            19:   run_user client.run_user
            20:   run_group client.run_group
            21: end
            22: 

           Compiled Resource:
           ------------------
           # Declared in /tmp/kitchen/cache/cookbooks/consul/recipes/default.rb:18:in `from_file'

           consul_config("/etc/consul.d/default.json") do
             action :create
             retries 0
             retry_delay 2
             default_guard_interpreter :default
             declared_type :consul_config
             cookbook_name "consul"
             recipe_name "default"
             run_user "consul"
             run_group "consul"
             path "/etc/consul.d/default.json"
           end

       [2015-03-09T20:46:36+00:00] ERROR: Converge failed with error message consul_config[/etc/consul.d/default.json] (consul::default line 18) had an error: NoMethodError: undefined method `parsed_run_user' for Chef::Resource::Directory

I looked into it and it would appear that the directory resource being used in consul_config is trying to use a class method from ConsulCookbook::Helpers, parsed_run_user. I see in some previous commits there was a change from run_user to service_user, and I wonder if this has just not been updated yet.

directory: https://github.com/johnbellone/consul-cookbook/blob/develop/libraries/provider_consul_config.rb#L20-L21
helper methods: https://github.com/johnbellone/consul-cookbook/blob/develop/libraries/helpers.rb#L13-L21

thanks in advance for any thoughts, let me know if I can help in anyway.

johnbellone · 2015-03-14T13:53:14Z

@fujin I have a whole bunch of commits I need to push. Apologies. They'll be coming in a few minutes.

coveralls · 2015-03-14T16:57:50Z

Coverage remained the same at 100.0% when pulling 09ad7ad on develop into 5208d86 on master.

johnbellone · 2015-04-02T13:02:46Z

I need to tear into this now that I am back from vacation. I'll see if I get some time to hack on it this evening.

johnbellone · 2015-05-21T21:35:09Z

This has become a beastly set of changes, but I am nearing completion. I need to open source a cookbook from work prior to release and thorough testing.

johnbellone · 2015-06-13T16:49:11Z

/cc @reset @someara

This is ready for review and merging.

@coderanger

@coderanger pointed out a few things that I could spruce up.

@coderanger

It seems that some people really dig runit. I don't get all the hype. But here it is courtesy of @coderanger.

The way that this cookbook is intended to work is for it to be included in a [base cookbook][0] or an [environment cookbook][1] so that the whole infrastructure built with poise-service uses runit. [0]: http://blog.vialstudios.com/the-environment-cookbook-pattern/#thebasecookbook [1]: http://blog.vialstudios.com/the-environment-cookbook-pattern/#theenvironmentcookbook

In all of RedHat's infinite wisdom it seems that upstart is available on EL6.6. The poise-service library cookbook we use defaults to that so we need to conver that test case in our integration tests.

This ensures that we can check for idempotence by simply using the normal Chef means. Its actually a hell of a lot better than querying Consul and doing some insane magic in the background.

Add HWRPs for installing and managing consul.

lock · 2020-04-25T09:55:56Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

johnbellone added the in progress label Feb 8, 2015

johnbellone mentioned this pull request Feb 8, 2015

Using provider instead of recipe for installing consul #113

Closed

someara reviewed Feb 8, 2015
View reviewed changes

libraries/provider_consul_client_source.rb

action :create do

include_recipe 'golang::default'

directory File.join(node['go']['gopath'], 'src/github.com/hashicorp') do

This comment was marked as outdated.

Sign in to view

johnbellone self-assigned this Feb 9, 2015

johnbellone added this to the Road to 1.0.0 milestone Feb 9, 2015

shanesveller mentioned this pull request Feb 24, 2015

Add support for Consul 0.5.0 and Atlas auto-join #135

Merged

johnbellone force-pushed the develop branch from 28e88e6 to 09ad7ad Compare March 14, 2015 16:51

johnbellone force-pushed the develop branch 2 times, most recently from 7a79ab5 to 2ec492a Compare June 13, 2015 16:48

johnbellone changed the title ~~WIP: Add HWRPs for installing and managing consul.~~ Add HWRPs for installing and managing consul. Jun 13, 2015

John Bellone and others added 21 commits July 24, 2015 23:39

Fixes the permissions on the private key.

c60909e

Adds data bag stub for consul integration testing.

ae2e692

Updates the directories and tests for /etc/consul.d/ssl.

25eccc8

Fixes a few bits after a code review.

beda08b

@coderanger pointed out a few things that I could spruce up.

Adds support for running Consul under runit provider.

faef8cf

It seems that some people really dig runit. I don't get all the hype. But here it is courtesy of @coderanger.

Cleans up the rubocop bits.

07dca12

Fixes a few more issues while test-kitchen converging.

e41c3d0

Fixes integration testing issues with CentOS 6.6 and upstart.

64a4532

In all of RedHat's infinite wisdom it seems that upstart is available on EL6.6. The poise-service library cookbook we use defaults to that so we need to conver that test case in our integration tests.

Fixes a bunch of issues with integration test harness.

b26421c

Adds support for creating consul service but not enabling.

56eddd3

Fixes issues with unit tests failing.

fc18d6c

Fixes permissions for key and certificate.

275877e

Adds more test converage to Consul configuration.

6cc4c6c

Adds more unit tests for resources.

fa8ac56

Modifies the watch resource to write out as a file.

ea9c597

This ensures that we can check for idempotence by simply using the normal Chef means. Its actually a hell of a lot better than querying Consul and doing some insane magic in the background.

Updates the README and defaults for various HWRP.

ccc0c3f

Adds test-kitchen support for Windows platform.

a74c9b2

Bumps version of libartifact-cookbook ~> 1.3.

8ad3ad2

Implements the Consul definition HWRP.

2267367

Fixes a few issues during the merge/rebase.

6371cd3

johnbellone added a commit that referenced this pull request Jul 25, 2015

Merge pull request #126 from johnbellone/develop

da91b27

Add HWRPs for installing and managing consul.

johnbellone merged commit da91b27 into master Jul 25, 2015

johnbellone deleted the develop branch July 25, 2015 03:42

johnbellone restored the develop branch July 25, 2015 03:42

johnbellone deleted the develop branch July 25, 2015 03:42

johnbellone mentioned this pull request Jul 26, 2015

resource and library to handle acls #203

Closed

johnbellone unassigned reset Mar 7, 2016

lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add HWRPs for installing and managing consul. #126

Add HWRPs for installing and managing consul. #126

johnbellone commented Feb 8, 2015

coveralls commented Feb 8, 2015

reset commented Feb 8, 2015

This comment was marked as outdated.

someara commented Feb 8, 2015

coveralls commented Feb 8, 2015

coveralls commented Feb 9, 2015

coveralls commented Feb 10, 2015

coveralls commented Feb 10, 2015

coveralls commented Feb 13, 2015

coveralls commented Feb 14, 2015

coveralls commented Feb 14, 2015

coveralls commented Feb 14, 2015

coveralls commented Feb 14, 2015

coveralls commented Feb 24, 2015

fujin commented Mar 9, 2015

johnbellone commented Mar 14, 2015

coveralls commented Mar 14, 2015

johnbellone commented Apr 2, 2015

johnbellone commented May 21, 2015

johnbellone commented Jun 13, 2015

lock bot commented Apr 25, 2020

Add HWRPs for installing and managing consul. #126

Add HWRPs for installing and managing consul. #126

Conversation

johnbellone commented Feb 8, 2015

coveralls commented Feb 8, 2015

reset commented Feb 8, 2015

This comment was marked as outdated.

someara commented Feb 8, 2015

coveralls commented Feb 8, 2015

coveralls commented Feb 9, 2015

coveralls commented Feb 10, 2015

coveralls commented Feb 10, 2015

coveralls commented Feb 13, 2015

coveralls commented Feb 14, 2015

coveralls commented Feb 14, 2015

coveralls commented Feb 14, 2015

coveralls commented Feb 14, 2015

coveralls commented Feb 24, 2015

fujin commented Mar 9, 2015

johnbellone commented Mar 14, 2015

coveralls commented Mar 14, 2015

johnbellone commented Apr 2, 2015

johnbellone commented May 21, 2015

johnbellone commented Jun 13, 2015

lock bot commented Apr 25, 2020