-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against owning /etc #254
Conversation
Current coverage is
|
@johnbellone, any reason to not change the default values for
? Although it would still be good to guard against common locations. |
I don't have any complaints here. |
@Ginja do you want to put a separate PR in? |
@Ginja would that be changing the defaults for |
I'd say both as I like to keep everything Consul in one location, but if anyone has any objections to that the default location for |
Before taking the easy way out and guarding
Leaving all things configuration in |
Now that I am reading this again I am a little concerned - the /etc/consul/data directory shouldn't be the default. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The
consul_config
resource ensures the directory exists for the config file and is owned by the service user. Unfortunately since the default path for the config file is/etc/config.json
, this cookbook is changing ownership of/etc
to the Consul user, which is causing problems on some of my nodes.This PR simply guards the directory resource from managing the directory if it is
/etc
. This may not be the best approach, but it was the simplest way to solve the problem. Please let me know if there's a better way and I'll submit another PR. Thanks!